Fix code quality issues in InternVL2_5 ksana_plugin_model.py#60
Open
hobostay wants to merge 1 commit intoTencent:mainfrom
Open
Fix code quality issues in InternVL2_5 ksana_plugin_model.py#60hobostay wants to merge 1 commit intoTencent:mainfrom
hobostay wants to merge 1 commit intoTencent:mainfrom
Conversation
- Replace bare except clause with specific ImportError exception The bare except clause catches all exceptions including SystemExit and KeyboardInterrupt, which is considered bad practice. - Remove duplicate IMG_CONTEXT_TOKEN constant definition The constant was defined twice on lines 41 and 44. These changes improve code quality and follow Python best practices.
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes code quality issues in
InternVL2_5/ksana_plugin_model.py.Changes
Replace bare
exceptclause with specificImportErrorexceptionexcept:clause (line 35)exceptcatches all exceptions includingSystemExitandKeyboardInterruptexcept ImportError:which is appropriate for optional importsRemove duplicate
IMG_CONTEXT_TOKENconstant definitionIMG_CONTEXT_TOKENwas defined twice (lines 41 and 44)Impact