Skip to content

Remove force unwrap from fileURL #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkostov merged 2 commits into from
Jun 5, 2026
Merged

Remove force unwrap from fileURL #291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7471bbe
fix: remove force unwrap from fileURL
ddaddy Jun 4, 2026
053fa8a
Apply suggestion from @kkostov
kkostov Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions Sources/TelemetryDeck/Signals/SignalCache.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,19 +60,17 @@ internal class SignalCache<T>: @unchecked Sendable where T: Codable {
}
}

private func fileURL() -> URL {
private func fileURL() throws -> URL {
if let cacheFileURL {
return cacheFileURL
}

// swiftlint:disable force_try
let cacheFolderURL = try! FileManager.default.url(
let cacheFolderURL = try FileManager.default.url(
for: .cachesDirectory,
in: .userDomainMask,
appropriateFor: nil,
create: false
)
// swiftlint:enable force_try

return cacheFolderURL.appendingPathComponent("telemetrysignalcache")
}
Expand All @@ -87,9 +85,16 @@ internal class SignalCache<T>: @unchecked Sendable where T: Codable {
}

private func loadFromDiskLocked() {
logHandler?.log(message: "Loading Telemetry cache from: \(fileURL())")
guard let data = try? Data(contentsOf: fileURL()) else { return }
try? FileManager.default.removeItem(at: fileURL())
guard let fileURL = try? fileURL() else {
logHandler?.log(
.error,
message: "Failed to get disk cache url from FileManager."
)
return
}
logHandler?.log(message: "Loading Telemetry cache from: \(fileURL)")
guard let data = try? Data(contentsOf: fileURL) else { return }
try? FileManager.default.removeItem(at: fileURL)
guard let signals = try? JSONDecoder().decode([T].self, from: data) else { return }
logHandler?.log(message: "Loaded \(signals.count) signals")
cachedSignals.append(contentsOf: signals)
Expand Down