Skip to content

fix some flacky tests #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkostov merged 3 commits into from
May 25, 2026
Merged

fix some flacky tests #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abb1efd
fix: some tests are flacky for now
kkostov May 18, 2026
b14b2d3
fix: watchos simulator name in ci
kkostov May 18, 2026
cc1bbed
chore: github runner update macos-26-arm64 (20260520) Image Update
kkostov May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,16 @@ jobs:
fail-fast: true
matrix:
xcodebuildCommand:
- "-sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 17'"
- "-sdk iphonesimulator -destination 'platform=iOS Simulator,OS=26.5,name=iPhone 17'"
- "-sdk macosx -destination 'platform=macOS'"
- "-sdk xrsimulator -destination 'platform=visionOS Simulator,name=Apple Vision Pro'"
- "-sdk appletvsimulator -destination 'platform=tvOS Simulator,name=Apple TV 4K (3rd generation)'"
- "-sdk watchsimulator -destination 'platform=watchOS Simulator,name=Apple Watch Series 11 (46mm)'"
- "-sdk xrsimulator -destination 'platform=visionOS Simulator,OS=26.5,name=Apple Vision Pro'"
- "-sdk appletvsimulator -destination 'platform=tvOS Simulator,OS=26.5,name=Apple TV 4K (3rd generation)'"
- "-sdk watchsimulator -destination 'platform=watchOS Simulator,OS=26.5,name=Apple Watch Series 11 (46mm)'"
- "build -destination 'platform=macOS,variant=Mac Catalyst'"
steps:
- name: Repository checkout
uses: actions/checkout@v6
- name: Select Xcode version
run: sudo xcode-select -s '/Applications/Xcode_26.4.1.app/Contents/Developer'
run: sudo xcode-select -s '/Applications/Xcode_26.5.0.app/Contents/Developer'
- name: Build and Test
run: xcodebuild test -scheme TelemetryDeck-Package ${{ matrix.xcodebuildCommand }}
2 changes: 1 addition & 1 deletion Tests/TelemetryDeckTests/SignalManagerBackoffTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ struct SignalManagerBackoffTests {
private func waitForConsecutiveFailures(
_ manager: SignalManager,
toEqual expected: Int,
timeout: TimeInterval = 5
timeout: TimeInterval = 15
) async throws {
let deadline = Date().addingTimeInterval(timeout)
while manager.consecutiveFailuresForTesting != expected, Date() < deadline {
Expand Down
4 changes: 2 additions & 2 deletions Tests/TelemetryDeckTests/SignalManagerDispositionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ struct SignalManagerDispositionTests {
private func waitForConsecutiveFailures(
_ manager: SignalManager,
toEqual expected: Int,
timeout: TimeInterval = 5
timeout: TimeInterval = 15
) async throws {
let deadline = Date().addingTimeInterval(timeout)
while manager.consecutiveFailuresForTesting != expected, Date() < deadline {
Expand All @@ -77,7 +77,7 @@ struct SignalManagerDispositionTests {
private func waitForSendCompletion(
_ manager: SignalManager,
toReach expected: Int,
timeout: TimeInterval = 5
timeout: TimeInterval = 15
) async throws {
let deadline = Date().addingTimeInterval(timeout)
while manager.sendCompletionsForTesting < expected, Date() < deadline {
Expand Down