Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 92.17% 91.79% -0.38%
==========================================
Files 11 15 +4
Lines 1418 1438 +20
==========================================
+ Hits 1307 1320 +13
- Misses 111 118 +7
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…f a separate class to make it easier to work on and to make removing the v1 api easier if we decide to do that)
Teester
force-pushed
the
entityshape-51
branch
from
20aeaa8 to
6d5df0f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #51. Moves the multiple classes in comparejsonld.py into separate files. Also moves getting the jsonld into a separate class from getting the shape for v1 of the api.