Repository navigation
fix(inventory): address issue #794 implementation audit - #889
Merged
Merged
Conversation
|
Review changes with |
|
Important Review skippedToo many files! This PR contains 670 files, which is 570 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (670)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…tory # Conflicts: # app/apps/shell-super-app/modern.config.ts # app/apps/shell-super-app/package.json # app/package.json # app/zerops.yaml
… files' matchers The two-host Outbox Worker host test matched its messages with a one-shot matchUnmatched call. That call reads the global unmatched queue, and outbox-runtime.test.ts runs its own matcher in parallel with only its own subscriptions. Whichever matcher locks a message first marks it matched, so the host test could lose messages without deliveries and wait forever for the last ones (main run 36602557477 hit the 30-minute job timeout). The test proves claiming, not matching, so insert each message already matched with one pending delivery per owner, as the actor-evidence test does.
…tory # Conflicts: # app/scripts/tests/stage-zerops-services.test.mts
…tory # Conflicts: # app/scripts/tests/stage-zerops-services.test.mts
…tory # Conflicts: # app/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All 10 findings from the issue #794 implementation audit are addressed. No Stock Block/Release, Availability, Order, Fulfillment, or Commerce Operations UI scope was added.
Validation
pnpm checkpnpm buildEnvironment limitation
The real PostgreSQL binding-correction integration suite compiles successfully and exercises the generated Action through Core runtime, but it could not execute locally because PostgreSQL/Docker was unavailable. It should run in a database-enabled CI environment.
Privacy prerequisite
The unsupported local privacy mini-protocol was removed rather than replaced with another invented contract. Inventory privacy adapter work under #858 remains blocked until the canonical #509/#595 shared Privacy Owner Contract exists.
Refs #794