Skip to content

fix(test): adopt effect-rstest PR #4 canary and drop the pnpm patch #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BleedingDev merged 2 commits into from
Sep 19, 2026
Merged

fix(test): adopt effect-rstest PR #4 canary and drop the pnpm patch #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45a0c95
fix(test): adopt effect-rstest PR #4 canary and drop the pnpm patch
BleedingDev Sep 19, 2026
3160860
docs(lint): describe the unpatched effect-rstest canary pin
BleedingDev Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/apps/shell-super-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"typescript": "7.0.2",
"wrangler": "4.116.0",
"zephyr-rspack-plugin": "1.2.4",
"effect-rstest": "0.1.4",
"effect-rstest": "https://pkg.pr.new/ScriptedAlchemy/effect-rstest@f29b3f495d45a11037334620bf5f693414fb5578",
"cross-env": "10.1.0",
"@modern-js/app-tools-extensions": "npm:@bleedingdev/modern-js-app-tools-extensions@3.9.0-ultramodern.11",
"@modern-js/plugin-bff-build-extensions": "npm:@bleedingdev/modern-js-plugin-bff-build-extensions@3.9.0-ultramodern.11",
Expand Down
2 changes: 1 addition & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
"@effect/sql-pg": "4.0.0-rc.112"
},
"devDependencies": {
"effect-rstest": "0.1.4",
"effect-rstest": "https://pkg.pr.new/ScriptedAlchemy/effect-rstest@f29b3f495d45a11037334620bf5f693414fb5578",

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Refresh the test-runtime guidance after removing the patch

When maintainers consult app/tools/oxlint/effect-native/README.md:84, it still states that the current canary uses a temporary pnpm patch and that issue #507 tracks deleting it. This commit pins the unpatched canary and closes that issue, so the authoritative guidance now contradicts the dependency configuration and can prompt someone to restore an obsolete patch; update that paragraph as part of this migration.

AGENTS.md reference: app/AGENTS.md:L3-L3

Useful? React with 👍 / 👎.

@BleedingDev BleedingDev Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 3160860: the paragraph now describes the unpatched canary pin, points at the installed-package guard test, and warns that npm effect-rstest releases are a separate publishing line without these fixes.

"@rstest/core": "0.11.12",
"@effect/platform-node": "4.0.0-rc.112",
"@effect/tsgo": "0.41.0",
Expand Down
2 changes: 1 addition & 1 deletion app/packages/core-runtime/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"@types/node": "^26.4.1",
"@types/pg": "8.20.0",
"drizzle-kit": "1.0.0-rc.5-ab785fc",
"effect-rstest": "0.1.4",
"effect-rstest": "https://pkg.pr.new/ScriptedAlchemy/effect-rstest@f29b3f495d45a11037334620bf5f693414fb5578",
"yaml": "2.9.1"
}
}
2 changes: 1 addition & 1 deletion app/packages/customer-payment-term-contracts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"devDependencies": {
"@rstest/core": "0.11.12",
"@types/node": "20.19.43",
"effect-rstest": "0.1.4"
"effect-rstest": "https://pkg.pr.new/ScriptedAlchemy/effect-rstest@f29b3f495d45a11037334620bf5f693414fb5578"
},
"ontosContractOwner": {
"appId": "commerce-customer-context",
Expand Down
2 changes: 1 addition & 1 deletion app/packages/email-delivery/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
"devDependencies": {
"@rstest/core": "0.11.12",
"@types/node": "^26.4.1",
"effect-rstest": "0.1.4"
"effect-rstest": "https://pkg.pr.new/ScriptedAlchemy/effect-rstest@f29b3f495d45a11037334620bf5f693414fb5578"
}
}
2 changes: 1 addition & 1 deletion app/packages/gateway-principal-verifier/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"devDependencies": {
"@types/node": "^26.4.1",
"effect-rstest": "0.1.4",
"effect-rstest": "https://pkg.pr.new/ScriptedAlchemy/effect-rstest@f29b3f495d45a11037334620bf5f693414fb5578",
"@rstest/core": "0.11.12"
}
}
2 changes: 1 addition & 1 deletion app/packages/payment-term-catalog-contracts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"devDependencies": {
"@rstest/core": "0.11.12",
"@types/node": "20.19.43",
"effect-rstest": "0.1.4"
"effect-rstest": "https://pkg.pr.new/ScriptedAlchemy/effect-rstest@f29b3f495d45a11037334620bf5f693414fb5578"
},
"ontosContractOwner": {
"appId": "payment-term-catalog",
Expand Down
2 changes: 1 addition & 1 deletion app/packages/shared-contracts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
},
"devDependencies": {
"@types/node": "^26.4.1",
"effect-rstest": "0.1.4",
"effect-rstest": "https://pkg.pr.new/ScriptedAlchemy/effect-rstest@f29b3f495d45a11037334620bf5f693414fb5578",
"@rstest/core": "0.11.12"
}
}
68 changes: 0 additions & 68 deletions app/patches/effect-rstest@0.1.4.patch
View file
Open in desktop

This file was deleted.

55 changes: 27 additions & 28 deletions app/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading