Skip to content

ci: add quality-gate job required by the master ruleset - #640

Merged
BleedingDev merged 2 commits into
masterfrom
ci/quality-gate
Oct 11, 2026
Merged

BleedingDev merged 2 commits into
masterfrom
ci/quality-gate

Conversation

@BleedingDev

@BleedingDev BleedingDev commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Why the change

The Master ruleset requires a quality-gate check that no workflow on master produces, so every PR shows as blocked and can only be merged through an admin bypass.

Special things to note

Change outline

 .github/workflows/ci.yml
 jobs:
   main:            # unchanged: install, typecheck, nx affected lint+test, package checks
+  quality-gate:    # always runs after main
+    needs: [main]
+    passes only if main == success   # required by the Master ruleset

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • The release pipeline now reports the result of its primary checks and fails when they do not succeed. No end-user-facing changes are included.

The Master ruleset requires a 'quality-gate' status check, but no workflow
on master produced one, so every PR showed as blocked and needed an admin
bypass. The job mirrors the result of the existing 'main' CI job.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@semanticdiff-com

semanticdiff-com Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  .github/workflows/ci.yml  0% smaller

@vercel

vercel Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
new-engine-ui-storybook Ready Ready Preview Oct 8, 2026 7:54pm UTC

@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High impact] The PR appears safe to merge.

Summary

Adds quality-gate as the stable check required by the master ruleset.

  • The gate runs after main and fails unless every job in needs succeeds.
  • The previous finding is fixed: adding another job to needs now makes that job blocking without another change.
  • No new actionable issues found.

Reviews (2) · Last reviewed commit: "ci: make quality-gate check every job in..." · Reviewed by Greptile

Comment thread .github/workflows/ci.yml Outdated
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0813ddea-1719-46cd-b6ea-f3aea72169c1
📥 Commits

Reviewing files that changed from the base of the PR and between dc1bf71 and 23d370a.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ff12bab2-f4c6-4f6f-92c0-a7899ed685c2
📥 Commits

Reviewing files that changed from the base of the PR and between 1eaa87e and dc1bf71.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: main
🔇 Additional comments (1)
.github/workflows/ci.yml (1)

94-110: LGTM!


Walkthrough

The CI workflow adds a quality-gate job. It runs after main and fails when main does not succeed.

Changes

CI quality gate

Layer / File(s) Summary
Check main job result
.github/workflows/ci.yml
The quality-gate job always runs after main, reports its result, and exits with an error if the result is not success.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to dc1bf

For non-cancelled pull-request runs, the quality gate reports whether the main job succeeded and fails otherwise. No concrete change-specific merge risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a required CI quality gate for the master ruleset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@BleedingDev
BleedingDev merged commit adfcb5c into master Oct 11, 2026
7 checks passed
@BleedingDev
BleedingDev deleted the ci/quality-gate branch October 11, 2026 20:14
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 0.54.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This branch was successfully deployed

1 active deployment
Preview — 23d370aa Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant