fix(frontend): align dashboard card heights#126
Merged
Conversation
979d655 to
e63168c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the frontend dashboard playback cards to use a single shared “video-style” card layout (notably a consistent 2:3 thumbnail frame) so that video and music cards—and their loading skeletons—align to the same height and action-button position.
Changes:
- Standardize dashboard playback card structure via shared class constants and a 2:3 thumbnail frame.
- Add a dashboard “loading sessions” skeleton card grid that matches the final card layout.
- Extend component workflow tests to cover skeleton rendering and music (square artwork) rendering inside the shared frame.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/frontend/src/components/frontendWorkflow.test.ts | Adds/updates SSR markup tests to assert the new skeleton grid and shared 2:3 card framing (including music track cards). |
| apps/frontend/src/components/DashboardScreen.tsx | Refactors playback card markup/classes into shared constants and introduces a skeleton grid shown while sessions are loading. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e63168c to
a7affbc
Compare
a7affbc to
08f199f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation