feat(watermelon): as 2nd background option main#32
Open
adamchenwei wants to merge 1 commit intoTechForPalestine:mainfrom
Open
feat(watermelon): as 2nd background option main#32adamchenwei wants to merge 1 commit intoTechForPalestine:mainfrom
adamchenwei wants to merge 1 commit intoTechForPalestine:mainfrom
Conversation
Author
|
@janajri what you think brotha? |
adamchenwei
commented
Feb 8, 2024
| import download from 'downloadjs'; | ||
| import { toPng } from 'html-to-image'; | ||
| import Image from 'next/image'; | ||
| "use client"; |
Author
There was a problem hiding this comment.
btw I think my VSCode just did a massive formatting refactor on the page... not sure its what you want though 🤔 let me know I can remove pretty much all of them and just leave the code, or if you want just part of the refactor, I can help to clean some of them.
Member
|
Surely a 2nd background defeats the purpose |
Author
how so? 🤔 care to elaborate? |
Member
It seems to me the purpose is to have a common background that is recognizable, and having 2 (or 3 or 4) is less compelling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-02-07.at.6.24.59.PM.mov