Write findings as a GitLab Code Quality report - #20
Merged
Merged
Conversation
--format gitlab prints the findings --format github annotates as Code Quality issues, major when they fail the gate and minor otherwise, with JevGate's fingerprints. The site shows a merge request pipeline that uploads it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Phase 3 of the roadmap:
--format gitlabprints a GitLab Code Quality report, so merge requests show JevGate's findings in the widget and on the changed lines.--format githubannotates (new, not notes):description(message and next step),check_name(rule ID),fingerprint(JevGate's, or a hash of rule, path and line when a finding has none),severity(majorwhen it fails the gate,minorotherwise) andlocation.path/lines.--watch, like the other document formats.How it was checked
Unit test for severity, location, lines and both fingerprint cases; a dry run prints
[]. The pipeline example follows GitLab's documentedartifacts:reports:codequality, but hasn't run on GitLab.