Accept single findings with an allow comment - #14
Merged
Merged
Conversation
tauanbinato
force-pushed
the
inline-suppressions
branch
from
September 25, 2026 23:00
b203e57 to
fc836ee
Compare
A comment jevgate: allow(RULE) reason on a finding's line, or in the comments and attributes directly above it, accepts the finding as the baseline does. The reason is required; the report keeps the finding with it, the gate counts it apart, and jevgate baseline leaves it out.
tauanbinato
force-pushed
the
inline-suppressions
branch
from
September 26, 2026 02:19
fc836ee to
4c20cff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Phase 3 of the roadmap: accept one finding where it is, instead of in
jevgate-baseline.json.jevgate: allow(RULE[, RULE…]) reasonin any comment style (//,#,/* */,<!-- -->,--). RULE is a rule ID, key or group, as everywhere else. A-,:or—before the reason is dropped.#[attributes]can sit in between; a blank line or code ends the block. For findings with several locations (shared logic), the finding's own line counts.suppressed: "<reason>", never fails the gate, is left out of annotations and SARIF, and is counted asgate.suppressed_findings. Agent output shows(allowed: reason).jevgate baselinedoesn't copy it, so deleting the comment brings the finding back.jevgate:as a tool directive, so the allow comment is never judged as a comment to clean up.Questions for review
allow(...)the right verb? Alternatives:ignore,accept.baseline stats?How it was checked