fix: 팀 프로젝트 업무 위젯 레이아웃 겹침 보정#86
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 10 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough대시보드 레이아웃 정규화 함수를 추가하고, 레이아웃 상태 변경 및 그리드 렌더링에 적용했습니다. 아이템 크기·위치를 보정하고 위젯 간 겹침을 해소합니다. Changes대시보드 레이아웃 정규화
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/features/dashboard/edit-layout/model/useDashboardLayout.ts`:
- Line 30: useState의 초기화에서 normalizeLayout(initialLayout.layout)로 원본과 다른 보정 결과가
생성되면, 첫 렌더를 건너뛰는 저장 effect와 별도로 해당 초기 결과를 saveDashboardLayout에 한 번 영속화하세요. 원본과
정규화 결과가 동일할 때는 저장하지 않고, 이후 레이아웃 변경에 대한 기존 저장 동작은 유지하세요.
In `@src/shared/dashboard/lib/normalize-layout.ts`:
- Around line 19-25: clampLayoutItem에서 w/h만 고정하지 말고 item의 minW, minH, maxW, maxH
제약도 함께 정규화하세요. 병합된 실제 제약 범위를 반영해 최소·최대값이 일관되도록 보정한 뒤, 해당 범위 안에서 width와 height를
계산하고 기존 cols 제한과 x/y 보정은 유지하세요.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 8e2de53c-a602-4127-868a-3e9f6b06a858
📒 Files selected for processing (3)
src/features/dashboard/edit-layout/model/useDashboardLayout.tssrc/shared/dashboard/lib/normalize-layout.tssrc/views/dashboard/ui/DashboardGrid.tsx
2 participants
Pull Request
작업 내용
작업 결과
npm run lint,npm run typecheck통과했습니다.변경 사항
Added
normalizeLayout유틸 추가Changed
Fixed
실행화면
테스트
리뷰 체크리스트
feature/*->develop, 배포 시develop또는release/*->main)Type/#issue-number/description형식을 따릅니다.console.log, 주석, 임시 코드를 제거했습니다.리뷰 요청사항
관련 이슈
Closes #85
Summary by CodeRabbit