Draft
Conversation
- Create phase-8.ts module with placeholder structure - Add Phase 8 section to phase index with placeholder comment - Prepare infrastructure for future Phase 8 tag implementations - No specific tags implemented yet - ready for development
- Add Phase8Follow type definition with required url field - Implement podcastFollow parser with proper validation - Add podcastFollow field to FeedObject interface in Phase 8 section - Register podcastFollow in phase processing pipeline - Add comprehensive test coverage (7 test cases) - Handle edge cases: missing url, empty url, whitespace-only url - Support multiple follow tags (takes first one) - All tests pass (311 total tests) - Clean build successful
- Replace podnews.net URL with radiotopia.fm in test - Aligns with the Radiotopia feed reference - All tests still pass (7/7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements the
podcast:followtag as confirmed for Phase 8 of the Podcast Namespace. The tag allows podcasters to provide a JSON file containing URLs to their podcast on various platforms.Changes
Core Implementation
Phase8Followtype: Simple type with requiredurlfieldpodcastFollowparser: Validates and extracts the URL from the tagFeedObjectinterface:podcastFollowfield in Phase 8 sectionTag Specification Compliance
<channel>elementurl(required) - URL pointing to a JSON file<podcast:follow url="https://examplehost.com/feed/12345678/followlinks.json"/>Test Coverage
Quality Assurance
Implementation Details
The
podcast:followtag is implemented as a feed-level tag that:urlattributepc20supportmetadataReady for Review
This implementation provides complete support for the
podcast:followtag specification and is ready for review and merge.