Skip to content

Add immune entity configuration for Heisei Dream - #30

Open
WinDanesz wants to merge 2 commits into
TeamDimensional:1.12from
WinDanesz:heisei-immunity
Open

WinDanesz wants to merge 2 commits into
TeamDimensional:1.12from
WinDanesz:heisei-immunity

Conversation

@WinDanesz

Copy link
Copy Markdown

No description provided.

@Wizzerinus Wizzerinus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I've left some notes, I can fix them myself if it's too difficult for you to carve time here @WinDanesz

Comment thread src/main/java/vazkii/botania/common/core/handler/ConfigHandler.java Outdated
Comment thread src/main/java/vazkii/botania/common/core/handler/ConfigHandler.java
@WinDanesz

Copy link
Copy Markdown
Author

Thank you for the PR! I've left some notes, I can fix them myself if it's too difficult for you to carve time here @WinDanesz

Good points, thanks for reviewing. Updated now

@Wizzerinus Wizzerinus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge when I publish the next version, which should be soon

@WinDanesz

Copy link
Copy Markdown
Author

I raised this to have some boss immunities in Ars Magica. Should I add their entries as a default config or you prefer to keep this empty? Maybe some other vanilla and modded bosses should go in it too

@Wizzerinus

Copy link
Copy Markdown
Member

Adding some bosses would be a good idea, yeah

I apologize for my slowness in regards to merging, I am struggling to carve out time for this but should get it done this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants