Conversation
Wizzerinus
approved these changes
Sep 7, 2026
Wizzerinus
left a comment
Wizzerinus
left a comment
Member
There was a problem hiding this comment.
Looks good, will be merging for 376
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate Bauble Case and Flower Bag data back from Capabilities to NBT. According to VazkiiMods#1894 and VazkiiMods#2709, the Caps are the issue, which seems to be the case.
Testing it is simple :
The NBT migration piggy-backs off the older NBT format, so the old migration to Caps is not needed anymore. Migration from Caps is handled the first time, as the item is initialized without NBT. There doesn't seem to be any loss during migration and after restart. Due to piggy-packing off the old format, back-migration is also seamless.