Skip to content

팀 종료 동의 API 클라이언트 반영 - #98

Merged
hwangjokim merged 1 commit into
mainfrom
feat/97-team-finish-agreement
Jun 5, 2026
Merged

팀 종료 동의 API 클라이언트 반영#98
hwangjokim merged 1 commit into
mainfrom
feat/97-team-finish-agreement

Conversation

@hwangjokim

Copy link
Copy Markdown
Member

Summary

  • 서버의 팀 스페이스 종료 동의 API를 클라이언트 API 함수, Query mutation, MSW mock, OpenAPI 문서에 반영했습니다.
  • 팀 스페이스 관리 탭에서 종료 동의 액션, 성공 피드백, 완료 상태를 확인할 수 있게 했습니다.
  • 활성 팀 스페이스가 없을 때 안내 상태를 표시해 종료 이후 흐름도 자연스럽게 처리합니다.

Validation

  • pnpm typecheck
  • pnpm biome lint .
  • pnpm build
  • Browser QA: /team -> 관리 탭 -> 종료 동의 클릭 -> agreed 상태 및 disabled 버튼 확인
  • Browser QA: mobile viewport에서 종료 동의 섹션 가로 overflow 없음 확인

Closes #97

@vercel

vercel Bot commented Jun 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
client Ready Ready Preview, Comment Jun 5, 2026 7:30pm

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17cb71dabb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +315 to +316
const hasCurrentUserAgreedFinish =
finishState.agreedProjectGroupId === currentProjectGroupId;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Persist finish agreement status from the API

After a member records a finish agreement, this state is stored only in component state, so a page reload, route remount, or fresh login loses it and the Manage tab shows pending with the finish button enabled again even though the server has already recorded the agreement. Because GET /project-groups/me currently has no finish-agreement field, the UI cannot restore the recorded state after the query is refetched; expose/consume that status instead of deriving it solely from transient local state.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in c5913be. The client now persists successful finish agreement records per project group and user, then restores the agreed/disabled state after reload or remount while keeping the server API as the source of the write action.

@hwangjokim
hwangjokim force-pushed the feat/97-team-finish-agreement branch from 17cb71d to c5913be Compare June 5, 2026 19:29
@hwangjokim
hwangjokim merged commit d246eef into main Jun 5, 2026
3 checks passed
@hwangjokim
hwangjokim deleted the feat/97-team-finish-agreement branch June 5, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

팀 종료 동의 API 클라이언트 반영

1 participant