Skip to content

fix(team): render team rule markdown in view mode - #121

Merged
hwangjokim merged 1 commit into
mainfrom
fix/120-team-rule-render-mode
Jun 17, 2026
Merged

fix(team): render team rule markdown in view mode#121
hwangjokim merged 1 commit into
mainfrom
fix/120-team-rule-render-mode

Conversation

@hwangjokim

Copy link
Copy Markdown
Member

Summary

  • 팀 룰 기본 화면에서 원본 Markdown textarea 대신 렌더링된 문서 형태로 보여줍니다.
  • 수정 버튼을 누른 편집 모드에서만 Markdown 원본을 노출합니다.
  • Markdown heading/list/inline code를 안전하게 React 요소로 파싱해 표시합니다.

Validation

  • pnpm tsc --noEmit
  • pnpm biome lint .
  • pnpm build

Closes #120

@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
client Ready Ready Preview, Comment Jun 17, 2026 1:39am

@hwangjokim
hwangjokim merged commit de1a79b into main Jun 17, 2026
3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70ad84ec8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}

const headingPattern = /^(#{1,6})\s+(.+)$/;
const unorderedListPattern = /^(\s*)[-*]\s+(.+)$/;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Render numbered lists as lists

When a team rule uses a numbered Markdown list such as 1. .../2. ..., this pattern does not match it, so parseParagraph treats the consecutive items as one paragraph and joins them with spaces. In view mode that collapses a valid Markdown list into a single line, even though the editor invites users to write Markdown; please recognize ordered-list markers as list blocks too.

Useful? React with 👍 / 👎.

}

return (
<p className="text-sm leading-7 text-muted-foreground">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Prevent long paragraphs from overflowing

For paragraph-only rule text that contains a long unbroken value such as a repository URL, issue link, or branch name, this preview paragraph lacks the break-words protection that headings and list items have, so the rendered view can overflow the panel instead of wrapping. Adding the same word-breaking behavior here keeps non-list Markdown content within the card.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

팀 룰 Markdown 보기 모드 개선

1 participant