[codex] implement team-space server APIs - #107
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b33c88d1e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| allOf: | ||
| - $ref: '#/components/schemas/DevGuideHistory' | ||
| - $ref: '#/components/schemas/DevGuideContent' |
There was a problem hiding this comment.
When validating GET /team-space/{projectGroupId}/dev-guide/history/{devGuideId}, this allOf combines DevGuideHistory and DevGuideContent, but both referenced schemas set additionalProperties: false. A response containing both the history fields and the guide content is rejected by each subschema as having extra properties, so generated validators/clients will treat every successful history-content response as invalid. Define this response as a single closed object, or use a composition strategy that does not close each subschema independently.
Useful? React with 👍 / 👎.
| refetchOnWindowFocus: false, | ||
| retry: false, | ||
| staleTime: devGuideStaleTimeMs, |
There was a problem hiding this comment.
After a successful manual regeneration while the history list was already fetched, the new version remains absent from this query for up to the 60s stale window because useRegenerateDevGuideMutation only updates the devGuide query and never invalidates teamSpaceQueryKeys.devGuideHistories. In that scenario the UI shows the regenerated guide but the version-history panel still lists the old versions, so the user cannot select or confirm the newly generated version until a later refetch/reload.
Useful? React with 👍 / 👎.
1 participant
Summary
Why
The server already exposed Team Space dev-guide history/confirmation and GitHub weekly summary endpoints, but the client did not yet consume them. This brings the client API surface back in sync with the server and keeps the newly exposed UI readable across desktop and mobile layouts.
Validation
./node_modules/.bin/tsc -p tsconfig.app.json --noEmit./node_modules/.bin/biome lint ../node_modules/.bin/tsc -b./node_modules/.bin/vite buildhttp://127.0.0.1:5173/teamfor guide history, confirm action, and GitHub weekly summary UI.1440x900and mobile390x844after polish changes.