feat(resume): 이력서 업로드/관리 기능 구현 및 실제 API 연동#24
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
i3months
reviewed
May 19, 2026
| validateResumeFile, | ||
| } from '@/features/resume/lib/file-validation' | ||
|
|
||
| const FAKE_PROGRESS_DURATION_MS = 1_500 |
| onError?: (message: string) => void | ||
| } | ||
|
|
||
| export function UploadResumeButton({ onError }: Props) { |
Member
There was a problem hiding this comment.
resumedropzone 과 유사한 내용인듯한데. 하나로 공통화해서 쓸 수 있지 않을까 싶네요.
커스텀 훅으로 빼도 좋구요.
Contributor
Author
There was a problem hiding this comment.
오 거의 복붙 수준의 로직이었어서 바로 훅으로 분리했습니다.
좋은 리뷰네요 :)
| function ResumeCard({ resume }: { resume: ResumeResponse }) { | ||
| const remove = useDeleteResumeMutation() | ||
| const handleDelete = () => { | ||
| const ok = window.confirm( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
📋 작업 요약
이력서 도메인(
features/resume) 슬라이스를 생성하고, 파일 업로드, 목록 조회, 삭제 기능의 UI 로직과 실제 백엔드 API 연동을 완료했습니다.✨ 주요 변경 사항
api/resume.ts)POST,GET,DELETE /api/resumes엔드포인트와 통신하는 실제 코드를 작성했습니다. (Mock 데이터 미사용)useResumes.ts)ResumeDropzone컴포넌트ResumeList컴포넌트confirm)을 추가했습니다.💡 리뷰어 참고 사항
feature/workspace-layoutPR을 베이스로 확인해 주세요.