Feature/auth core logic#20
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
csh1668
approved these changes
May 16, 2026
i3months
reviewed
May 16, 2026
| '/api/auth/github/callback', | ||
| { | ||
| params: { code, state }, | ||
| withCredentials: true, |
Member
There was a problem hiding this comment.
이전 PR 에서 baseConfig에 withCredentials가 true로 설정되어있던데
여기서 다시 설정해주네요
강조하기 위해서 였다면 상관없긴합니다
Contributor
Author
There was a problem hiding this comment.
코드 다듬을 시간이 적어서 중복이 생겼네요. 강조의도는 없었고 중복을 줄이는 방향이 좋아보입니다.
|
|
||
| export async function logout(): Promise<void> { | ||
| await apiClient.delete('/api/auth/logout', { | ||
| withCredentials: true, |
| import type { AuthUser, LoginResponse } from './types' | ||
|
|
||
| export type AuthStatus = | ||
| | 'idle' |
Member
There was a problem hiding this comment.
[단순질문] idle과 loading 이 어떤 차이일까요?
Contributor
Author
There was a problem hiding this comment.
확장성을 위한 타입이지만, 저희 컨벤션상 미리 정의해두는 코드는 지양하자고 되어있네요. 일단 없애고 필요해질 때 사용하는것이 맞아보입니다.
| onError?: (error: unknown) => void | ||
| } | ||
|
|
||
| const BASE_CLASS = |
Member
There was a problem hiding this comment.
비슷한 버튼이 늘어난다면 shared 로 뺴는 것도 괜찮아보입니다.
Contributor
Author
There was a problem hiding this comment.
동의합니다. 두번까지는 각각 사용해도 문제가 없다고 생각하고 3번정도 겹칠 때 분리를 고려하면 좋을 것 같아요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
📌 작업 목적
인증 도메인(
features/auth)에 종속적인 비즈니스 로직과 UI 컴포넌트를 구현합니다.(PR 1의
shared계층을 기반으로 작성되었습니다.)🛠️ 주요 변경 사항
AuthContext,AuthProvider,useAuth커스텀 훅 구현features/auth/api/)GithubLoginButton, 라우트 가드를 위한RequireAuth컴포넌트 구현