Feature/auth shared client#19
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
i3months
reviewed
May 16, 2026
|
|
||
| export const apiClient = axios.create(baseConfig) | ||
|
|
||
| const refreshClient = axios.create(baseConfig) |
Member
There was a problem hiding this comment.
apiClient와 refreshClient가 별도로 만드셨군요 좋습니다
| return next | ||
| } | ||
|
|
||
| // 401과 403을 분리할 필요가 있다고 생각햤습니다. |
Member
There was a problem hiding this comment.
정말 정말 사소하지만 오타가 있네요
다른 부분은 모두 좋습니다
Member
There was a problem hiding this comment.
401 403은 백엔드 쪽이랑 얘기해봐야 명확하게 정할 수 있겠네요
Contributor
Author
There was a problem hiding this comment.
주석은 추후에 API명세를 명확히 하고 제거할 예정이라 그대로 둘게요 :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
📌 작업 목적
Github OAuth 및 향후 API 통신을 위한 기반 인프라와 공용 클라이언트를 세팅합니다.
(이 PR은 도메인 로직에 의존하지 않는 순수
shared계층 작업입니다.)🛠️ 주요 변경 사항
axios,@tanstack/react-query,react-router-domshared/api/client.ts에 Axios 인스턴스 생성shared/api/token-store.ts세팅