-
Notifications
You must be signed in to change notification settings - Fork 0
[Refactor] Implement Non-blocking preview image lookup and image meta data persisted #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c19a8bc
refactor: Implement S3AsyncClient for Non-blocking preview image lookup
LeeHanEum 2a95f9b
Merge remote-tracking branch 'origin/develop' into refactor/flowerspoโฆ
LeeHanEum a841c82
feat: add log temporally
LeeHanEum 8365c82
feat: temporally set as blocking s3client
LeeHanEum a71587d
feat: add logs to check querying time
LeeHanEum 6f7be33
feat: restore to use async client
LeeHanEum 4ba9d52
feat: add log fetching time non-blocking s3 client
LeeHanEum cec9b6c
feat: disable cache
LeeHanEum b4c8379
refactor: replace S3 ListObjectsV2 per spot with stored preview imageโฆ
LeeHanEum 86c44a4
feat: add logs to get querying time each stage
LeeHanEum e408371
feat: remove unnecessary logs and improve readability
LeeHanEum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
pida-clients/aws-client/src/main/kotlin/com/pida/client/aws/s3/AwsS3AsyncClient.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package com.pida.client.aws.s3 | ||
|
|
||
| import kotlinx.coroutines.future.await | ||
| import org.springframework.stereotype.Component | ||
| import software.amazon.awssdk.services.s3.S3AsyncClient | ||
| import software.amazon.awssdk.services.s3.model.ListObjectsV2Request | ||
| import software.amazon.awssdk.services.s3.model.S3Object | ||
|
|
||
| @Component | ||
| class AwsS3AsyncClient( | ||
| private val s3AsyncClient: S3AsyncClient, | ||
| ) { | ||
| suspend fun listObjects( | ||
| bucketName: String, | ||
| filePath: String, | ||
| ): List<S3Object> { | ||
| val allObjects = mutableListOf<S3Object>() | ||
| var continuationToken: String? = null | ||
|
|
||
| do { | ||
| val request = | ||
| ListObjectsV2Request | ||
| .builder() | ||
| .bucket(bucketName) | ||
| .prefix(filePath) | ||
| .maxKeys(1000) | ||
| .continuationToken(continuationToken) | ||
| .build() | ||
|
|
||
| val response = s3AsyncClient.listObjectsV2(request).await() | ||
| allObjects.addAll(response.contents()) | ||
| continuationToken = response.nextContinuationToken() | ||
| } while (response.isTruncated) | ||
|
|
||
| return allObjects | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
pida-core/core-domain/src/main/kotlin/com/pida/flowerspot/FlowerSpotUpdater.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| package com.pida.flowerspot | ||
|
|
||
| import org.springframework.stereotype.Component | ||
| import java.time.LocalDateTime | ||
|
|
||
| @Component | ||
| class FlowerSpotUpdater( | ||
| private val flowerSpotRepository: FlowerSpotRepository, | ||
| ) { | ||
| suspend fun updatePreviewImageKey( | ||
| spotId: Long, | ||
| key: String, | ||
| ) { | ||
| flowerSpotRepository.updatePreviewImageKey(spotId, key, LocalDateTime.now()) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.