Skip to content

Conversation

@yuechao-qin
Copy link
Collaborator

@yuechao-qin yuechao-qin commented Jan 22, 2026

Description

Refactored the PublishedComponentDetails component to improve code debugging and readability. The changes include:

  • Extracted the component interface into a dedicated PublishedComponentDetailsProps type
  • Converted the skeleton component from an arrow function to a regular function declaration
  • Extracted the main component content into a separate PublishedComponentDetailsContent function
  • Simplified the conditional rendering of the outdated component warning using logical AND (&&) instead of ternary operator

Type of Change

  • Cleanup/Refactor

Tests

  • Shows PublishedComponentDetails in Chrome React Dev Tools
    • image.png

@yuechao-qin yuechao-qin changed the title fix: Refactor SuspenseWrapper for PublishedComponentDetails for improved debugging refactor: Refactor SuspenseWrapper for PublishedComponentDetails for improved debugging Jan 22, 2026
@yuechao-qin yuechao-qin marked this pull request as ready for review January 22, 2026 19:57
@yuechao-qin yuechao-qin requested a review from a team as a code owner January 22, 2026 19:57
@yuechao-qin yuechao-qin force-pushed the ycq/fix-published-component-details-suspense-wrapper branch from 1291acd to e56e4da Compare January 22, 2026 20:15
@yuechao-qin yuechao-qin force-pushed the ycq/fix-comp-details-scroll branch 2 times, most recently from 9e258f5 to a3f4780 Compare January 22, 2026 20:18
@yuechao-qin yuechao-qin force-pushed the ycq/fix-published-component-details-suspense-wrapper branch 2 times, most recently from eb70c38 to 91c1696 Compare January 22, 2026 22:25
@yuechao-qin yuechao-qin force-pushed the ycq/fix-comp-details-scroll branch 3 times, most recently from 84fffca to ca5b111 Compare January 22, 2026 22:28
@yuechao-qin yuechao-qin force-pushed the ycq/fix-published-component-details-suspense-wrapper branch from 91c1696 to e4fc2b2 Compare January 22, 2026 22:29
@yuechao-qin yuechao-qin changed the base branch from ycq/fix-comp-details-scroll to graphite-base/1679 January 22, 2026 22:32
@yuechao-qin yuechao-qin force-pushed the ycq/fix-published-component-details-suspense-wrapper branch from e4fc2b2 to e1bd635 Compare January 22, 2026 22:32
@graphite-app graphite-app bot changed the base branch from graphite-base/1679 to master January 22, 2026 22:32
@yuechao-qin yuechao-qin force-pushed the ycq/fix-published-component-details-suspense-wrapper branch from e1bd635 to db360aa Compare January 22, 2026 22:32
@yuechao-qin yuechao-qin force-pushed the ycq/fix-published-component-details-suspense-wrapper branch from db360aa to 5f6625d Compare January 23, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants