Skip to content

fix: keep full-width resizable example sizes in sync with layout - #6608

Open
minwookshin wants to merge 1 commit into
TanStack:v8from
minwookshin:fix/full-width-resize-example-5870
Open

minwookshin wants to merge 1 commit into
TanStack:v8from
minwookshin:fix/full-width-resize-example-5870

Conversation

@minwookshin

Copy link
Copy Markdown

Fixes #5870 in the v8 React example.

Size the table from getTotalSize() with a full-width minimum and define leaf widths in a colgroup. Fixed layout keeps grouped headers and body cells aligned while the existing wrapper handles horizontal scrolling.

Checked repeated grow/shrink drags, group resizing, alignment and scroll containment at 390, 900 and 1440px in Chromium, Firefox and WebKit (nine cases). The regression fails on the original example. Example build and formatting passed. TypeScript reports the same existing unused parameter in makeData.ts:39 on both revisions; it passes with that unused-parameter check disabled.

@changeset-bot

changeset-bot Bot commented Oct 3, 2026

Copy link
Copy Markdown

鈿狅笍 No Changeset found

Latest commit: df8620b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

鈿欙笍 Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0f50f83e-8d2c-407b-afe9-e6ddd5420b97

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 馃攳 Trigger review
  • Autopilot 路 Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

鉂わ笍 Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant