fix: simplify some column pinning + visibility memo deps and performance#6259
Conversation
|
View your CI Pipeline Execution ↗ for commit bee3017
☁️ Nx Cloud last updated this comment at |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We add @tanstack/match-sorter-utils as a direct dependency of examples/vue/with-tanstack-query to fix the Rolldown build failure introduced when @tanstack/vue-query was bumped to 5.100.10, which added an import of @tanstack/match-sorter-utils in its devtools bundle. The pnpm lockfile is updated accordingly to resolve it to the local workspace package, consistent with how all other examples in the repo declare this dependency.
Tip
✅ We verified this fix by re-running tanstack-vue-table-example-with-tanstack-query:build.
Suggested Fix changes
diff --git a/examples/vue/with-tanstack-query/package.json b/examples/vue/with-tanstack-query/package.json
index 815faba9..b66ec0c2 100644
--- a/examples/vue/with-tanstack-query/package.json
+++ b/examples/vue/with-tanstack-query/package.json
@@ -10,6 +10,7 @@
},
"dependencies": {
"@faker-js/faker": "^10.4.0",
+ "@tanstack/match-sorter-utils": "^9.0.0-alpha.4",
"@tanstack/vue-query": "^5.100.10",
"@tanstack/vue-store": "^0.11.0",
"@tanstack/vue-table": "^9.0.0-alpha.45",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index ba0e5164..cc5e2590 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -7464,6 +7464,9 @@ importers:
'@faker-js/faker':
specifier: ^10.4.0
version: 10.4.0
+ '@tanstack/match-sorter-utils':
+ specifier: workspace:*
+ version: link:../../../packages/match-sorter-utils
'@tanstack/vue-query':
specifier: ^5.100.10
version: 5.100.10(vue@3.5.34(typescript@6.0.3))
✅ The fix was applied locally; push changes to this branch.
View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
🎯 Changes
✅ Checklist
pnpm test:pr.