fix: revert plugin changes, allow createMiddleware self compilation, fix HMR tests#7396
Open
Sheraff wants to merge 5 commits into
Open
fix: revert plugin changes, allow createMiddleware self compilation, fix HMR tests#7396Sheraff wants to merge 5 commits into
Sheraff wants to merge 5 commits into
Conversation
Contributor
|
View your CI Pipeline Execution ↗ for commit 8ce33ee
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview42 package(s) bumped directly, 0 bumped as dependents. 🟨 Minor bumps
|
Contributor
Bundle Size Benchmarks
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This reverts commit 2bd877c.
Contributor
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We replaced the unnecessary as type assertion on csrfCtx with an explicit type annotation on the variable declaration, which resolves the @typescript-eslint/no-unnecessary-type-assertion ESLint error. Since ctx is typed as any, asserting it with as does not change the resulting type, making the assertion redundant. This change preserves the intended typing of csrfCtx while satisfying the linting rules.
Tip
✅ We verified this fix by re-running @tanstack/start-client-core:test:eslint.
Warning
The suggested diff is too large to display here, but you can view it on Nx Cloud ↗
Or Apply changes locally with:
npx nx-cloud apply-locally oNnh-5WY9
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7373 assumed
createMiddlewarewould be imported internally and still be compiled away IIF the compiler was made recursive.It seemed to work, but also the compiler broke HMR E2E tests (and possibly actual HMR, not just tests).
Instead, this PR reverts the compiler changes, and adds a
createMiddlewarestub (registered in the plugin) so it still gets compiled away.This works well, but is a little weird for "where to put the code", the stub is untyped because all types live alongside the actual implementation.
Another solution could be to move the implementation of
createCsrfMiddlewaretostart-server-coremaybe? We attempt this alternative fix in #7400