fix(react-query): scope error boundary reset by query#10707
Open
raashish1601 wants to merge 1 commit into
Open
fix(react-query): scope error boundary reset by query#10707raashish1601 wants to merge 1 commit into
raashish1601 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryErrorResetBoundaryreset consumption byqueryHashinstead of a single global booleanuseQuery,useQueries, and suspense fetch failures so sibling queries cannot consume another query's reset@tanstack/react-queryFixes #2712.
Validation
corepack pnpm --dir packages/react-query exec vitest run src/__tests__/QueryResetErrorBoundary.test.tsxcorepack pnpm --dir packages/react-query exec vitest run src/__tests__/useSuspenseQuery.test.tsx src/__tests__/useQueries.test.tsxcorepack pnpm --filter @tanstack/react-query test:eslint(with temporary local symlink shim; 0 errors, existing warnings only)corepack pnpm --dir packages/react-query exec tsc --noEmit -p tsconfig.codex.json(temporary local tsconfig excluding Windows symlink placeholders)git diff --checkNote: this checkout has
core.symlinks=false, so package symlink config files are materialized as plain text on Windows. I used temporary local shims for lint/type validation and restored them before committing.build:tsupreached JS/TSC build success but DTS generation failed locally because API Extractor could not resolveajv/dist/corefrom this pnpm install.