test(query-devtools/Devtools): add tests for "Bulk Edit Data" mode switch, save, and invalid JSON#10687
Merged
Merged
Conversation
…itch, save, and invalid JSON
Contributor
📝 WalkthroughWalkthroughThis pull request adds a new test suite to validate the "Bulk Edit Data" feature in Query Devtools. Three test cases verify that clicking "Bulk Edit Data" opens the JSON editor, that valid JSON submissions update query data in the QueryClient, and that invalid JSON submissions display an "Invalid Value" error in the UI. ChangesData Edit Test Coverage
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 120a0b6
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/query-devtools/src/__tests__/Devtools.test.tsx (1)
677-689: ⚡ Quick winAlso assert data is unchanged after invalid JSON submit.
On Line 688, you assert the error state, but not the cache invariant. Adding a cache assertion prevents regressions where invalid input still mutates query data.
Suggested test addition
fireEvent.submit(textarea.closest('form')!) expect(rendered.getByText('Invalid Value')).toBeInTheDocument() + expect(queryClient.getQueryData(['edit-invalid'])).toEqual({ name: 'a' })🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/query-devtools/src/__tests__/Devtools.test.tsx` around lines 677 - 689, The test "should set an error state when the edited data is invalid JSON" currently asserts the error UI but not that the cache was left unchanged; after submitting the invalid JSON (when you call fireEvent.submit on textarea.closest('form') in that test), add an assertion that queryClient.getQueryData(['edit-invalid']) still equals the original object ({ name: 'a' }) to ensure the cache invariant is preserved—use the same query key ['edit-invalid'] and the existing queryClient variable in the test.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/query-devtools/src/__tests__/Devtools.test.tsx`:
- Around line 677-689: The test "should set an error state when the edited data
is invalid JSON" currently asserts the error UI but not that the cache was left
unchanged; after submitting the invalid JSON (when you call fireEvent.submit on
textarea.closest('form') in that test), add an assertion that
queryClient.getQueryData(['edit-invalid']) still equals the original object ({
name: 'a' }) to ensure the cache invariant is preserved—use the same query key
['edit-invalid'] and the existing queryClient variable in the test.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 822e4ce9-a11d-42dc-b872-d0b82b02ae19
📒 Files selected for processing (1)
packages/query-devtools/src/__tests__/Devtools.test.tsx
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Add tests for the data editor in the query details panel of the
Devtoolsbody component.data edit—"Bulk Edit Data"flow:"Bulk Edit Data"is clicked."Invalid Value"when the form is submitted with invalid JSON.✅ Checklist
🚀 Release Impact
Summary by CodeRabbit