Skip to content

Release 0.55.0#189

Merged
tudddorrr merged 7 commits intomainfrom
develop
Mar 27, 2026
Merged

Release 0.55.0#189
tudddorrr merged 7 commits intomainfrom
develop

Conversation

@tudddorrr
Copy link
Copy Markdown
Contributor

No description provided.

@tudddorrr tudddorrr added the release This pull request contains a release label Mar 27, 2026
@claude
Copy link
Copy Markdown

claude bot commented Mar 27, 2026

PR Review: Release 0.55.0\n\nThe prop array system and account migration features are well-structured overall. A few items worth addressing:\n\n### Potential Bug\n\nHandleAccountMigrated clears session token but does not persist a new one\n\nClearSession(false) deletes TaloSessionToken from PlayerPrefs, but HandleAccountMigrated never saves a new token. InvokeIdentifiedEvent fires so the player is identified for this session, but on the next app launch CheckForSession() returns false and autoStartSession will not re-identify them.\n\nIf migration is intentionally designed to require re-authentication via the external service on next launch, that should be documented. If a session token is available post-migration, it should be persisted via SaveSession.\n\n### Minor Issues\n\nSetPropArray throws NullReferenceException on null input - values.Where(...) throws an unguarded NRE if null is passed. A null guard at the top is consistent with the existing argument validation in the method.\n\nRemoving DEBUG from test-mode detection - The change from #if UNITY_EDITOR || DEBUG to #if UNITY_EDITOR means NUnit detection no longer runs in standalone development builds. If intentional (tests only run in Editor), a brief comment explaining the reasoning would prevent future confusion.

@tudddorrr tudddorrr merged commit abf10af into main Mar 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release This pull request contains a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant