Skip to content

Ensure test mode only runs in the Unity editor#187

Merged
tudddorrr merged 1 commit intodevelopfrom
ensure-editor-testmode
Mar 21, 2026
Merged

Ensure test mode only runs in the Unity editor#187
tudddorrr merged 1 commit intodevelopfrom
ensure-editor-testmode

Conversation

@tudddorrr
Copy link
Copy Markdown
Contributor

@tudddorrr tudddorrr commented Mar 21, 2026

Fixes #186

@tudddorrr tudddorrr added the fix This pull request contains a fix label Mar 21, 2026
@claude
Copy link
Copy Markdown

claude bot commented Mar 21, 2026

This PR looks good. The single-line fix is correct and well-scoped.

Summary of change: Removing || DEBUG from the #if UNITY_EDITOR || DEBUG guard in CheckTestMode() ensures NUnit detection (and the resulting RequestMock activation) can only occur inside the Unity editor, not in debug builds of a shipped game. The old condition was unnecessary risk — a DEBUG build would not normally contain the NUnit assembly, but the check was still running, leaving open the possibility of accidentally enabling test mode in a non-editor context.

No issues found across any category. Clean fix.

@tudddorrr tudddorrr merged commit 55f9647 into develop Mar 21, 2026
2 checks passed
@tudddorrr tudddorrr deleted the ensure-editor-testmode branch March 21, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix This pull request contains a fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Development build for Android fails

1 participant