Conversation
Add IdentifyGooglePlayGames API
|
PR Review: Release 0.54.0 The Google Play Games integration is straightforward and follows existing patterns. One concrete issue to address: Code Quality / Potential Bug Unencoded authCode in URL query parameter IdentifyGooglePlayGames passes authCode directly to Identify(), which constructs the URL as: {baseUrl}/identify?service=google_play_games&identifier={authCode} Google Play Games server-side auth codes from RequestServerSideAccess() are OAuth 2.0 authorization codes that contain literal / characters (e.g. 4/0AfJohXl...). Without encoding, the / is interpreted as a path separator, corrupting the URL and causing the request to fail or hit the wrong endpoint. Steam tickets are hex-encoded so they are URL-safe; Google Play Games auth codes are not. This is why the pre-existing Identify() implementation works fine for Steam but breaks here. Fix - encode in IdentifyGooglePlayGames before passing to Identify: public async Task IdentifyGooglePlayGames(string authCode) Alternatively, encoding the identifier inside Identify() itself would protect all future callers. Other categories |
No description provided.