Skip to content

Migrate player auth docs#64

Merged
tudddorrr merged 2 commits intomainfrom
migrate-auth-docs
Mar 27, 2026
Merged

Migrate player auth docs#64
tudddorrr merged 2 commits intomainfrom
migrate-auth-docs

Conversation

@tudddorrr
Copy link
Copy Markdown
Contributor

No description provided.

@claude
Copy link
Copy Markdown

claude bot commented Mar 22, 2026

Documentation Review: PR #64

Nice additions overall - the migration docs are clear, and the error code section is a welcome addition to the HTTP API docs.


🔴 Admonition closing delimiter indented

In both docs/godot/identifying.mdx and docs/unity/identifying.mdx, the closing ::: of the admonition block was changed to have 2-space indentation. In Docusaurus, admonition closing delimiters must be at column 0. Indenting ::: means the renderer will not recognise it as the closing delimiter, causing the admonition to either not close or render raw text to the user.

Fix: Revert both changes back to unindented :::.


🔵 Undeclared variables in Unity migration example

In docs/unity/player-authentication.mdx, the OnAuthCallback method references currentPassword and validationLabel without them being declared in the snippet. The Godot equivalent uses @onready annotations to make dependencies explicit. A developer copying this Unity snippet will not know the type of currentPassword or where validationLabel comes from.

Fix: Add field declarations at the top of the snippet, for example: [SerializeField] private TMP_InputField currentPassword; and [SerializeField] private TMP_Text validationLabel;


No issues found in:

  • Description metadata updates (Google Play addition) - accurate
  • EMAIL_TAKEN and INVALID_MIGRATION_TARGET error docs - clear and match existing format
  • Migration success behaviour - documented correctly for both Unity and Godot
  • Cross-references to Steamworks and Google Play Games integration pages - correct

@tudddorrr tudddorrr merged commit be17b53 into main Mar 27, 2026
1 check passed
@tudddorrr tudddorrr deleted the migrate-auth-docs branch March 27, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant