Conversation
|
Documentation Review: Google Play Games Integration Overall this is a well-structured addition. The new integration page, prop documentation, and merge-limitation updates are clear. One critical code issue in the Unity section needs fixing. CRITICAL: Unity code sample has missing generic type parameters The C# example in docs/unity/identifying.mdx uses raw non-generic List, which is invalid C# and would fail to compile. Current: private List selectedScopes = new List(); Current: List grantedScopes = authResponse.GetGrantedScopes(); MAJOR: Code sample structure is misleading The Unity snippet mixes class-level declarations (private List selectedScopes) with method-level code (.Add() calls, RequestServerSideAccess), without a wrapping method. A developer copying this will not know where each piece belongs. Suggest wrapping everything in a method, similar to how the Godot example uses _ready(). MINOR: grantedScopes is retrieved but unused In the Unity example, authResponse.GetGrantedScopes() is assigned to grantedScopes but never used. Developers will wonder if they need to act on it. Either use it or remove that line. No issues found in:
|
239c72c to
c774647
Compare
c774647 to
709b175
Compare
No description provided.