Add tests for Roman numeral regex validation #458
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while working with
LazyLock, I saw thatUPPER_ROMAN_NUMERALandLOWER_ROMAN_NUMERALhave two matching operators^at the start, making them not match leading whitespace. Is that the correct behaviour?The comment in the code sounds like they aren't really needed generally though.
in the added test cases, the ones with leading whitespace are failing (
cargo test test_roman_numeral_regex)