Skip to content

fix(plugin-oracle): make channel-fatal classification testable to unbreak test target #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 1 commit into from
Jun 21, 2026
+20 −19
Merged

fix(plugin-oracle): make channel-fatal classification testable to unbreak test target #1740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions Plugins/OracleDriverPlugin/OracleConnection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,16 +286,7 @@ final class OracleConnectionWrapper: @unchecked Sendable {
}

private static func isChannelFatal(_ error: OracleSQLError) -> Bool {
isChannelFatalCode(error.code.description)
}

static func isChannelFatalCode(_ codeDescription: String) -> Bool {
switch codeDescription {
case "connectionError", "messageDecodingFailure", "unexpectedBackendMessage":
return true
default:
return false
}
OracleChannelFatalCode.isChannelFatal(error.code.description)
}

func disconnect() {
Expand Down
12 changes: 12 additions & 0 deletions Plugins/TableProPluginKit/OracleChannelFatalCode.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import Foundation

public enum OracleChannelFatalCode {
public static func isChannelFatal(_ codeDescription: String) -> Bool {
switch codeDescription {
case "connectionError", "messageDecodingFailure", "unexpectedBackendMessage":
return true
default:
return false
}
}
}
16 changes: 7 additions & 9 deletions TableProTests/Plugins/OracleConnectionErrorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,19 @@
import Foundation
import Testing

@testable import TablePro
import TableProPluginKit

@Suite("Oracle channel-fatal error classification")
struct OracleConnectionErrorTests {
@Test("Decode and connection failures are treated as channel-fatal")
func channelFatalCodes() {
#expect(OracleConnectionWrapper.isChannelFatalCode("connectionError"))
#expect(OracleConnectionWrapper.isChannelFatalCode("messageDecodingFailure"))
#expect(OracleConnectionWrapper.isChannelFatalCode("unexpectedBackendMessage"))
#expect(OracleChannelFatalCode.isChannelFatal("connectionError"))
#expect(OracleChannelFatalCode.isChannelFatal("messageDecodingFailure"))
#expect(OracleChannelFatalCode.isChannelFatal("unexpectedBackendMessage"))
}

@Test("Server-side SQL errors keep the connection alive")
func nonFatalCodes() {
#expect(!OracleConnectionWrapper.isChannelFatalCode("server"))
#expect(!OracleConnectionWrapper.isChannelFatalCode("statementCancelled"))
#expect(!OracleConnectionWrapper.isChannelFatalCode("malformedStatement"))
#expect(!OracleChannelFatalCode.isChannelFatal("server"))
#expect(!OracleChannelFatalCode.isChannelFatal("statementCancelled"))
#expect(!OracleChannelFatalCode.isChannelFatal("malformedStatement"))
}
}
Loading