Skip to content

fix(coordinator): build all split panes through one path so a new tab's inspector renders #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 1 commit into from
Jun 18, 2026
+4 −8
Merged

fix(coordinator): build all split panes through one path so a new tab's inspector renders #1713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- A new database group now appears in the connection list right away instead of only after restarting the app. (#1704)
- The SQL formatter keeps nested indentation for UNION, UNION ALL, INTERSECT, and EXCEPT inside a derived table or CTE, and puts the closing parenthesis of a subquery on its own line instead of collapsing it onto the last SELECT. (#1698)
- Toolbar button tooltips now show each action's real keyboard shortcut and follow your custom bindings, instead of a fixed value. The Switch Connection tooltip showed the wrong shortcut. (#1694)
- The row detail panel no longer stays blank when a table is opened in a second tab. The panel now shows the selected row right away instead of only after the inspector is toggled.

## [0.51.1] - 2026-06-16

Expand Down
11 changes: 3 additions & 8 deletions TablePro/Core/Services/Infrastructure/MainSplitViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,14 +193,14 @@ internal final class MainSplitViewController: NSSplitViewController, InspectorVi
splitView.dividerStyle = .thin
splitView.isVertical = true

sidebarContainer = SidebarContainerViewController(rootView: AnyView(buildSidebarView()))
sidebarContainer = SidebarContainerViewController(rootView: AnyView(Color.clear))
sidebarSplitItem = NSSplitViewItem(sidebarWithViewController: sidebarContainer)
sidebarSplitItem.canCollapse = true
sidebarSplitItem.minimumThickness = Self.sidebarMinThickness
sidebarSplitItem.maximumThickness = Self.sidebarMaxThickness
addSplitViewItem(sidebarSplitItem)

detailHosting = NSHostingController(rootView: AnyView(buildDetailView()))
detailHosting = NSHostingController(rootView: AnyView(Color.clear))
detailSplitItem = NSSplitViewItem(viewController: detailHosting)
detailSplitItem.minimumThickness = Self.detailMinThickness
detailSplitItem.holdingPriority = .defaultLow
Expand All @@ -216,12 +216,7 @@ internal final class MainSplitViewController: NSSplitViewController, InspectorVi
splitView.autosaveName = splitAutosaveName
applyDefaultCollapseStateIfNoAutosave()

if let session = currentSession, session.driver != nil, let coordinator = sessionState?.coordinator {
sidebarContainer.updateSidebarState(
SharedSidebarState.forConnection(session.connection.id),
windowState: coordinator.windowSidebarState
)
}
rebuildPanes()
}

override func splitViewDidResizeSubviews(_ notification: Notification) {
Expand Down
Loading