Skip to content

fix: detect quoted Windows runtime processes and prefer LocalAgent CLI - #4

Open
Taor233 wants to merge 1 commit into
Tabbit-Browser:mainfrom
Taor233:fix/windows-cli-detection
Open

fix: detect quoted Windows runtime processes and prefer LocalAgent CLI#4
Taor233 wants to merge 1 commit into
Tabbit-Browser:mainfrom
Taor233:fix/windows-cli-detection

Conversation

@Taor233

@Taor233 Taor233 commented Aug 16, 2026

Copy link
Copy Markdown

Problem

  • On Windows, Get-CimInstance returns quoted command lines such as "...browser-runtime-service.mjs" ..., so the runtime-process regex missed the running service and tabbit_browser_install reported restart-required even when the Runtime was ready.
  • The Browser-owned user launcher on Windows lives at %LOCALAPPDATA%\Tabbit\LocalAgent\bin\tabbit-cli.exe, but discovery could prefer a bundled tabbit-playwright-cli.exe helper, and the skill instructed models to invoke ~/.local/bin/tabbit-cli, which does not exist in that layout.

Changes

  • installer.js: accept quotes around runtime-process paths; check %LOCALAPPDATA%\Tabbit\LocalAgent\bin\tabbit-cli.{exe,cmd} before ~/.local/bin and bundled helpers.
  • index.js: include cliPath in tabbit_browser_install results for ready, restart-required, and background.
  • Skill docs: prefer the reported cliPath; document platform defaults for Windows PowerShell, Windows Git Bash, and macOS/Linux.
  • Tests: quoted Windows process command lines, LocalAgent preference, and the cliPath output field.

Testing

  • New and updated tests pass (npm test).
  • Four pre-existing tests still fail only on Windows because they assert POSIX path separators; the identical failures reproduce on clean main, so they are out of scope here.
  • npm pack --dry-run is clean.
  • Live check on Windows 11: detectTabbit() now returns ready with cliPath pointing at the LocalAgent launcher, and a nodejs smoke task opened example.com and returned the title.

Match quoted Windows process command lines so browser-runtime-service.mjs is recognized while the Runtime Service is running, and prefer the Browser-owned LocalAgent launcher at %LOCALAPPDATA%\Tabbit\LocalAgent\bin\tabbit-cli.exe over bundled helpers. Expose the discovered launcher as cliPath in the install tool result and teach the skill to use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant