fix: detect quoted Windows runtime processes and prefer LocalAgent CLI - #4
Open
Taor233 wants to merge 1 commit into
Open
fix: detect quoted Windows runtime processes and prefer LocalAgent CLI#4Taor233 wants to merge 1 commit into
Taor233 wants to merge 1 commit into
Conversation
Match quoted Windows process command lines so browser-runtime-service.mjs is recognized while the Runtime Service is running, and prefer the Browser-owned LocalAgent launcher at %LOCALAPPDATA%\Tabbit\LocalAgent\bin\tabbit-cli.exe over bundled helpers. Expose the discovered launcher as cliPath in the install tool result and teach the skill to use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Get-CimInstancereturns quoted command lines such as"...browser-runtime-service.mjs" ..., so the runtime-process regex missed the running service andtabbit_browser_installreportedrestart-requiredeven when the Runtime was ready.%LOCALAPPDATA%\Tabbit\LocalAgent\bin\tabbit-cli.exe, but discovery could prefer a bundledtabbit-playwright-cli.exehelper, and the skill instructed models to invoke~/.local/bin/tabbit-cli, which does not exist in that layout.Changes
installer.js: accept quotes around runtime-process paths; check%LOCALAPPDATA%\Tabbit\LocalAgent\bin\tabbit-cli.{exe,cmd}before~/.local/binand bundled helpers.index.js: includecliPathintabbit_browser_installresults forready,restart-required, andbackground.cliPath; document platform defaults for Windows PowerShell, Windows Git Bash, and macOS/Linux.cliPathoutput field.Testing
npm test).main, so they are out of scope here.npm pack --dry-runis clean.detectTabbit()now returnsreadywithcliPathpointing at the LocalAgent launcher, and anodejssmoke task openedexample.comand returned the title.