[DOCS] Add ADR-005: Inline CI workflows for render-guides - #26
Open
linawolf wants to merge 1 commit into
Open
Conversation
render-guides#1196 proposed migrating the main.yaml workflow of render-guides to the shared PHP workflows of this repository (reusable-php-tests.yml, reusable-php-quality.yml, reusable-php-command.yml). The pull request was closed on 2026-09-13. This records why, so the question is answerable without digging through a closed pull request. The reason is amortisation: the three PHP workflows have no callers today — the only mention of reusable-php-tests anywhere in the organization is this repository's README.md. render-guides would be the sole consumer, so "maintained in one place instead of once per repository" has no second repository to amortise against. Two costs would be incurred immediately for that absent benefit. The actions in main.yaml are SHA-pinned and currently ahead of the shared workflows (setup-php 2.37.2 versus 2.37.1, actions/cache v6.1.0 versus v5.0.3), and adoption at @main would let a push here change the CI of render-guides without review there. And six of the seven required status checks would be renamed, with three checks that are gated today as steps inside Quality needing explicit listing in the merge-queue ruleset from ADR-004, or they stop gating silently. The decision is explicitly reversible: it is revisited when a second PHP repository adopts the shared PHP workflows, at which point render-guides should follow rather than remain the exception. Signed-off-by: lina.wolf Assisted-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019EuSAzF5qw81NzPusWy2hC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
render-guides#1196 proposed migrating the main.yaml workflow of
render-guides to the shared PHP workflows of this repository
(reusable-php-tests.yml, reusable-php-quality.yml,
reusable-php-command.yml). The pull request was closed on 2026-09-13.
This records why, so the question is answerable without digging through
a closed pull request.
The reason is amortisation: the three PHP workflows have no callers
today — the only mention of reusable-php-tests anywhere in the
organization is this repository's README.md. render-guides would be the
sole consumer, so "maintained in one place instead of once per
repository" has no second repository to amortise against.
Two costs would be incurred immediately for that absent benefit. The
actions in main.yaml are SHA-pinned and currently ahead of the shared
workflows (setup-php 2.37.2 versus 2.37.1, actions/cache v6.1.0 versus
v5.0.3), and adoption at @main would let a push here change the CI of
render-guides without review there. And six of the seven required status
checks would be renamed, with three checks that are gated today as steps
inside Quality needing explicit listing in the merge-queue ruleset from
ADR-004, or they stop gating silently.
The decision is explicitly reversible: it is revisited when a second PHP
repository adopts the shared PHP workflows, at which point render-guides
should follow rather than remain the exception.