Skip to content

#591_StateOfCharge_not_available_when_polling#599

Open
matt-wirtz wants to merge 1 commit into
masterfrom
591_StateOfCharge_not_available_when_polling
Open

#591_StateOfCharge_not_available_when_polling#599
matt-wirtz wants to merge 1 commit into
masterfrom
591_StateOfCharge_not_available_when_polling

Conversation

@matt-wirtz

Copy link
Copy Markdown
Collaborator

Added new enpoint /collections/asset-info/items to provide asset information. Moved assetInfo to the core.

@matt-wirtz matt-wirtz linked an issue Apr 22, 2026 that may be closed by this pull request

@edwinvandenbelt edwinvandenbelt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't have an id (assetInfo). This makes it traceable. Use the legId instead.

Comment thread TOMP-API-1-CORE.yaml
type: object
description: asset status information
properties:
id:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a legId. The TO and MP know how to derive the assetId from the legId. This way, we avoid the problem of traceablity.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really necessary to hide the asset id in the response?

What is returned here: The MP calling this endpoint get's all the assets that were assigned to legs which were created on behalf of the calling MP.

summary: >-
        Retrieve asset info for assets that are assigned to a leg. Only  legs
        are included that were created on behalf of the calling party.

So the MP only get's the info for assets which he initially requested to be booked. So he does not gain more info about assets compared to what he should already know. I don't think it's necessary to hide the asset info here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: stateOfCharge not available when polling

2 participants