Repository navigation
feat(app): improve sharing controls, recovery and troubleshooting - #455
Merged
Merged
Conversation
Sharing failures previously lost useful context behind generic messages, leaving users unsure what to try or include in a report. This patch retains the known failure boundary and makes the existing television status icon open concise troubleshooting, diagnostics and safe copy actions. The candidate starts from v1.8.0 and includes only failure guidance, matching bilingual documentation and the current work ledger. It preserves Browser/server v23, Native control v9, capture v7 and the 1440p ceiling. Capture, routing, retry behavior, permissions and recording opt-in remain with their existing owners. The retained 4K/media candidate, audio-exclusion refinements, website refinements and Magicsock work are separate. Validation: - `npm run check`: type checks, 79 test files / 1339 tests and Web production build passed. - `npm run check:go`: Go tests, formatting, vet, supported cross-builds and Windows capture build/probes passed. Native macOS SDK checks require a macOS runner and were skipped by the existing policy. - `npm run gate:app-local`: Chrome 154 / Windows App startup, access bootstrap, Host UI, local invitation and cleanup passed. - Documentation checks, repository hygiene and documentation-site build passed. - Browser review: all eight troubleshooting examples in Chinese and English fit a 320 x 640 viewport; guide links, detailed 403 guidance, modal focus, Escape and focus restoration verified. Desktop dark-theme presentation reviewed. This improves reporting and guidance; it does not establish the causes of unmatched field failures. Physical device/network coverage remains in the existing TODO ledger. ## Release notes ### 中文 这是一次提示与排查体验的维护更新,帮助用户在分享失败时找到原因线索和下一步操作。保持 v1.8.0 的通信协议与媒体行为。 - 点击电视下方的错误图标,可查看排查建议、复制失败信息,并打开诊断或问题排查文档。 - 区分 App 请求超时、连接中断、采集失败与媒体连接失败;改善房间关闭、会话接管、设备不可用和播放异常的中英文提示。 - 更新中英文教程与问题排查,补充 403、1033、WebRTC 限制、校园网、显卡与游戏采集、HDR 过曝及画面模糊/中断的检查步骤。 ### English This maintenance update makes sharing failures easier to understand and troubleshoot. It retains v1.8.0's communication protocols and media behavior. - Select the error icon below the television to see suggested checks, copy failure details, and open diagnostics or the troubleshooting guide. - Distinguish App request timeouts, disconnections, capture failures and media connection failures. Clarify room closure, session takeover, unavailable devices and playback errors in both languages. - Update the English and Chinese guides with checks for 403 and 1033 errors, WebRTC restrictions, campus networks, GPU and game capture issues, HDR overexposure, and blurred or interrupted video.
TNTcraftHIM
marked this pull request as ready for review
October 5, 2026 18:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharing failures were often reduced to a generic message, and changing Windows audio exclusion required reopening source selection. This phase keeps actionable failure context at the TV status indicator, adds live source-audio controls, and integrates independent capture, codec and ICE-lifetime repairs against the published contract.
The audio controls reuse source replacement and the existing mixer; audio-only changes preserve video capture, encoded sources and connections. Source enumeration is bounded by the serialized control response. Codec preflight and H.264 decoder input enforce the existing native format. Gateway mappings are revalidated only for actual ICE gatherings. Website scripts and styles now share content-addressed build output.
Browser/server v23, Native control v9, capture v7 and the 1440p ceiling stay unchanged. The held 4K/capability candidate and Magicsock transport are excluded. Documentation changes belong to the existing guides, standards and evidence owners.
Validation
npm run check: type checking, 81 test files / 1,370 tests and the production Web build passed.npm run check:go: Go tests, formatting, vet, cross-builds and Windows native capture regressions passed. A first run hit Windows temporary-directory cleanup after an unchanged SQLite test; five focused repetitions and the full rerun passed.Release notes
中文
这是一次分享体验与兼容性更新。Windows App 支持在开播后调整排除的应用声音;遇到分享失败时,也有更清楚的提示和排查入口。
使用改进
修复
更新 App 并刷新页面即可使用相应改进,无需迁移配置或房间数据。Windows 10 音频排除是否可用取决于系统能力。
English
This update improves sharing controls and compatibility. Windows App users can change audio exclusion during a share, and sharing failures now provide clearer guidance and a direct troubleshooting entry.
Improvements
Fixes
Update the App and reload the page to use the relevant improvements. No configuration or room-data migration is required. Windows 10 audio exclusion depends on actual system capability.