refactor: rename hdcp package to pipeline - #18
Merged
Conversation
internal/hdcp was a leftover from the project's original name (hdcp-go, before it became ignis) and read as an unrelated acronym next to the rest of the codebase. Renames it to internal/pipeline, matching the word already used throughout the docs and comments to describe this exact mechanism (the 17-level pipeline). Also renames internal/service/hdcp_service.go -> ignis_service.go to match the exported type it already contains, IgnisService.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/hdcpwas a leftover from the project's original name (hdcp-go, before it becameignis) and read as an unrelated acronym next to the rest of the codebase -- exactly the kind of naming ambiguity we're trying to eliminate.internal/hdcp->internal/pipeline(packagehdcp->pipeline). Matches the word already used throughout the docs/comments to describe this exact mechanism ("the 17-level pipeline") -- keptPipeline/NewPipelineas-is rather than introducing a new name likeCalculator, since the type's actual behavior (ordered stages, each depending on the last, with every intermediate level's result kept accessible viaLvl1...Lvl17) is precisely what "pipeline" describes; a name like "Calculator" would undersell that and would also collide with the neighboringinternal/calcpackage andCalculate*methods.internal/service/hdcp_service.go->ignis_service.go(+ test) to match the exported type it already contains,IgnisService.cmd/validate/main.go, whichgo buildcaught immediately.data/README.md's one prose mention.No exported symbol was named
Hdcp/HDCPanywhere, andinternal/isn't importable outside this module, so this is a self-contained rename with no external impact.Test plan
go build ./...,go vet ./...,go test ./...all pass locally