Skip to content

refactor: rename hdcp package to pipeline - #18

Merged
jravani merged 1 commit into
mainfrom
refactor/rename-hdcp-package-to-pipeline
Jul 27, 2026
Merged

refactor: rename hdcp package to pipeline#18
jravani merged 1 commit into
mainfrom
refactor/rename-hdcp-package-to-pipeline

Conversation

@jravani

@jravani jravani commented Jul 27, 2026

Copy link
Copy Markdown
Member

Summary

internal/hdcp was a leftover from the project's original name (hdcp-go, before it became ignis) and read as an unrelated acronym next to the rest of the codebase -- exactly the kind of naming ambiguity we're trying to eliminate.

  • Renamed internal/hdcp -> internal/pipeline (package hdcp -> pipeline). Matches the word already used throughout the docs/comments to describe this exact mechanism ("the 17-level pipeline") -- kept Pipeline/NewPipeline as-is rather than introducing a new name like Calculator, since the type's actual behavior (ordered stages, each depending on the last, with every intermediate level's result kept accessible via Lvl1...Lvl17) is precisely what "pipeline" describes; a name like "Calculator" would undersell that and would also collide with the neighboring internal/calc package and Calculate* methods.
  • Renamed internal/service/hdcp_service.go -> ignis_service.go (+ test) to match the exported type it already contains, IgnisService.
  • Fixed the one other importer, cmd/validate/main.go, which go build caught immediately.
  • Updated data/README.md's one prose mention.

No exported symbol was named Hdcp/HDCP anywhere, and internal/ isn't importable outside this module, so this is a self-contained rename with no external impact.

Test plan

  • go build ./..., go vet ./..., go test ./... all pass locally
  • CI passes on this branch

internal/hdcp was a leftover from the project's original name
(hdcp-go, before it became ignis) and read as an unrelated acronym
next to the rest of the codebase. Renames it to internal/pipeline,
matching the word already used throughout the docs and comments to
describe this exact mechanism (the 17-level pipeline).

Also renames internal/service/hdcp_service.go -> ignis_service.go to
match the exported type it already contains, IgnisService.
@jravani
jravani merged commit c12ef5a into main Jul 27, 2026
5 checks passed
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/validate/main.go 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@jravani
jravani deleted the refactor/rename-hdcp-package-to-pipeline branch July 27, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants