Refactor(client): HASHI-158 메뉴 섹션 네이밍 정리 - #151
Draft
yurimidaH wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 요약
Jira: HASHI-158
📚 작업 내용
RestaurantMenuSection을RestaurantMenuListSection으로 rename했습니다.🔎 상세 설명
기존
RestaurantMenuSection은 이름만 보면 식당 상세 페이지 전용 섹션처럼 보였지만, 실제로는 식당 상세의 메뉴 탭과 메뉴 상세 페이지의 “다른 메뉴” 목록에서 함께 사용되고 있었습니다.이번 PR에서는 컴포넌트의 실제 책임이 “메뉴 목록 렌더링”에 가깝다는 점을 드러내기 위해
RestaurantMenuListSection으로 이름을 정리했습니다.RestaurantOtherMenuSection은 기존처럼 “다른 메뉴” 제목과 카운트의 소유 책임을 유지하고, 실제 목록 렌더링은RestaurantMenuListSection이 담당합니다.💭 고민한 부분
고민한 문제
restaurantDetailfeature 안에 있어 소유 책임을 어디까지 조정할지 고민했습니다.고려한 선택지
최종 선택과 이유
RestaurantMenuListSection으로 rename했습니다.남은 고민