forked from DSpace/dspace-angular
-
Notifications
You must be signed in to change notification settings - Fork 1
Digital Collections Accessibility Sprint 5 #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tamu-sad-iii
wants to merge
23
commits into
tamu-dspace-9_x
Choose a base branch
from
dca-sprint5-staging
base: tamu-dspace-9_x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
cbc41fc
Conditionally set attribute role menubar when menu has sub sections
tamu-sad-iii fb7705b
Merge pull request #209 from TAMULib/dca-sprint5-204-205-206
tamu-sad-iii a3dcd37
Update config.tamu.yml
tamu-sad-iii b59d4f7
Add empty aria-label to default non value option
tamu-sad-iii e6a353f
Add appropriate label for select inputs
tamu-sad-iii 469604b
Use `keydown` event to invoke `toggleExpanded` before `cdkTreeNodeTog…
tamu-sad-iii 193ff13
Merge pull request #213 from TAMULib/dca-sprint5-203
tamu-sad-iii bf8e158
Customize browse by starts with component form for accessibility
tamu-sad-iii 20a7350
Merge pull request #210 from TAMULib/dca-sprint5-tamu-dev-config-update
tamu-sad-iii d5d5d56
Merge pull request #212 from TAMULib/dca-sprint5-207
tamu-sad-iii c0dcde2
Merge pull request #215 from TAMULib/dca-sprint5-214
tamu-sad-iii 81d6376
Add tamu theme search and search results component
tamu-sad-iii 52f6739
Resolve merge conflicts
tamu-sad-iii ff03161
Merge pull request #219 from TAMULib/dca-sprint5-216-merge
tamu-sad-iii 0a605aa
Rearrange i18n labels to prevent redundant screen reading
tamu-sad-iii 9f9a36c
Merge pull request #220 from TAMULib/dca-sprint5-staging-browse-by-te…
tamu-sad-iii b68ae0f
Correct search page i18n keys
tamu-sad-iii 32840d0
Merge pull request #221 from TAMULib/dca-sprint5-staging-fix-search-p…
tamu-sad-iii 9c75068
Add text underline to general search link
tamu-sad-iii ad2ad58
Add tamu customization comments to dso edit menu component
tamu-sad-iii 8983077
Add tamu customization comments to starts with date component
tamu-sad-iii 00476e1
Add tamu customization comments to `tamu` starts with text component
tamu-sad-iii afa9760
Merge pull request #222 from TAMULib/dca-sprint5-staging-post-demo-up…
tamu-sad-iii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 4 additions & 1 deletion
5
src/app/shared/dso-page/dso-edit-menu/dso-edit-menu.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| <!-- TAMU Customization - search page single h1 --> | ||
| <h1 class="sr-only">{{ 'search-page.heading' | translate }}</h1> | ||
| <!-- END TAMU Customization - search page single h1 --> | ||
| <!-- TAMU Customization - search page complete heading structure --> | ||
| <h2 class="sr-only">{{ 'search-page.configuration.heading' | translate }}</h2> | ||
| <!-- END TAMU Customization - search page complete heading structure --> | ||
| <ds-search [showCsvExport]="true" [trackStatistics]="true" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import { Component } from '@angular/core'; | ||
| import { TranslateModule } from '@ngx-translate/core'; | ||
|
|
||
| import { SearchConfigurationService } from '../../../../app/core/shared/search/search-configuration.service'; | ||
| import { SEARCH_CONFIG_SERVICE } from '../../../../app/my-dspace-page/my-dspace-configuration.service'; | ||
| import { SearchPageComponent as BaseComponent } from '../../../../app/search-page/search-page.component'; | ||
| import { ThemedSearchComponent } from '../../../../app/shared/search/themed-search.component'; | ||
|
|
||
| @Component({ | ||
| selector: 'ds-themed-search-page', | ||
| // styleUrls: ['./search-page.component.scss'], | ||
| templateUrl: './search-page.component.html', | ||
| providers: [ | ||
| { | ||
| provide: SEARCH_CONFIG_SERVICE, | ||
| useClass: SearchConfigurationService, | ||
| }, | ||
| ], | ||
| standalone: true, | ||
| imports: [ | ||
| TranslateModule, | ||
| ThemedSearchComponent, | ||
| ], | ||
| }) | ||
| export class SearchPageComponent extends BaseComponent { | ||
| } |
67 changes: 67 additions & 0 deletions
67
src/themes/tamu/app/shared/search/search-results/search-results.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| @if ((activeFilters$ | async).length > 0 && (appliedFilters$ | async).length === 0) { | ||
| <div class="row"> | ||
| <div class="col-12"> | ||
| <div class="filters-badge-skeleton-container"> | ||
| <div class="filter-badge-skeleton"> | ||
| <ngx-skeleton-loader [count]="(activeFilters$ | async).length" /> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| } | ||
|
|
||
| <div class="d-flex justify-content-between"> | ||
| <!-- TAMU Customization - single h1 on search page --> | ||
| <!-- | ||
| @if (!disableHeader) { | ||
| <h1>{{ (configuration ? configuration + '.search.results.head' : 'search.results.head') | translate }}</h1> | ||
| } | ||
| --> | ||
| <h2 [ngClass]="{ 'sr-only' : disableHeader }">{{ (configuration ? configuration + '.search.results.head' : 'search.results.head') | translate }}</h2> | ||
| <!-- END TAMU Customization - single h1 on search page --> | ||
| @if (showCsvExport) { | ||
| <ds-search-export-csv [searchConfig]="searchConfig" [total]="searchResults?.payload?.totalElements"></ds-search-export-csv> | ||
| } | ||
| </div> | ||
| @if (searchResults && searchResults?.hasSucceeded && !searchResults?.isLoading && searchResults?.payload?.page.length > 0) { | ||
| <div @fadeIn> | ||
| <ds-viewable-collection | ||
| [config]="searchConfig.pagination" | ||
| [sortConfig]="searchConfig.sort" | ||
| [objects]="searchResults" | ||
| [hideGear]="true" | ||
| [showRSS]="true" | ||
| [selectable]="selectable" | ||
| [selectionConfig]="selectionConfig" | ||
| [linkType]="linkType" | ||
| [context]="context" | ||
| [hidePaginationDetail]="hidePaginationDetail" | ||
| [showThumbnails]="showThumbnails" | ||
| (contentChange)="contentChange.emit($event)" | ||
| (deselectObject)="deselectObject.emit($event)" | ||
| (selectObject)="selectObject.emit($event)"> | ||
| </ds-viewable-collection> | ||
| </div> | ||
| } | ||
|
|
||
| @if (isLoading()) { | ||
| <ds-search-results-skeleton | ||
| [showThumbnails]="showThumbnails" | ||
| [numberOfResults]="searchConfig.pagination.pageSize" | ||
| ></ds-search-results-skeleton> | ||
| } | ||
|
|
||
| @if (showError()) { | ||
| <ds-error | ||
| message="{{errorMessageLabel() | translate}}"></ds-error> | ||
| } | ||
| @if (searchResults?.payload?.page.length === 0 || searchResults?.statusCode === 400) { | ||
| <div> | ||
| {{ 'search.results.no-results' | translate }} | ||
| <a [routerLink]="['/search']" | ||
| [queryParams]="{ query: surroundStringWithQuotes(searchConfig?.query) }" | ||
| queryParamsHandling="merge" role="link" tabindex="0"> | ||
| {{"search.results.no-results-link" | translate}} | ||
| </a> | ||
| </div> | ||
| } |
39 changes: 39 additions & 0 deletions
39
src/themes/tamu/app/shared/search/search-results/search-results.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import { AsyncPipe, CommonModule } from '@angular/common'; | ||
| import { Component } from '@angular/core'; | ||
| import { RouterLink } from '@angular/router'; | ||
| import { TranslateModule } from '@ngx-translate/core'; | ||
| import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader'; | ||
|
|
||
| import { | ||
| fadeIn, | ||
| fadeInOut, | ||
| } from '../../../../../../app/shared/animations/fade'; | ||
| import { ErrorComponent } from '../../../../../../app/shared/error/error.component'; | ||
| import { ObjectCollectionComponent } from '../../../../../../app/shared/object-collection/object-collection.component'; | ||
| import { SearchExportCsvComponent } from '../../../../../../app/shared/search/search-export-csv/search-export-csv.component'; | ||
| import { SearchResultsSkeletonComponent } from '../../../../../../app/shared/search/search-results/search-results-skeleton/search-results-skeleton.component'; | ||
| import { SearchResultsComponent as BaseComponent } from '../../../../../../app/shared/search/search-results/search-results.component'; | ||
|
|
||
| @Component({ | ||
| selector: 'ds-themed-search-results', | ||
| templateUrl: './search-results.component.html', | ||
| styleUrls: ['../../../../../../app/shared/search/search-results/search-results.component.scss'], | ||
| animations: [ | ||
| fadeIn, | ||
| fadeInOut, | ||
| ], | ||
| standalone: true, | ||
| imports: [ | ||
| AsyncPipe, | ||
| ErrorComponent, | ||
| NgxSkeletonLoaderModule, | ||
| ObjectCollectionComponent, | ||
| RouterLink, | ||
| SearchExportCsvComponent, | ||
| SearchResultsSkeletonComponent, | ||
| CommonModule, | ||
| TranslateModule, | ||
| ], | ||
| }) | ||
| export class SearchResultsComponent extends BaseComponent { | ||
| } |
20 changes: 20 additions & 0 deletions
20
src/themes/tamu/app/shared/starts-with/text/starts-with-text.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| <form class="w-100" [formGroup]="formData" (ngSubmit)="submitForm(formData.value)"> | ||
| <div class="mb-3"> | ||
| <div class="row"> | ||
| <div class="form-group input-group col-sm-12 col-md-6 col-auto"> | ||
| <input class="form-control" [attr.aria-label]="'browse.startsWith.input' | translate" placeholder="{{'browse.startsWith.placeholder' | translate}}" type="text" name="startsWith" formControlName="startsWith" [value]="getStartsWith()" /> | ||
| <span class="input-group-append"> | ||
| <button class="btn btn-primary" type="submit"><i class="fas fa-book-open"></i> {{'browse.startsWith.submit' | translate}}</button> | ||
| </span> | ||
| </div> | ||
| </div> | ||
| <!-- TAMU Customization - starts with input hint accessibility update --> | ||
| <small class="text-muted"> | ||
| <span aria-hidden="true">{{'browse.startsWith.hint' | translate}}. </span> | ||
| <span aria-hidden="true">{{'browse.startsWith.click_here' | translate}}</span> | ||
| <span><a class="text-decoration-underline" [attr.aria-label]="'browse.startsWith.type_text' | translate" [routerLink]="['../../search']">{{'browse.startsWith.general_search' | translate}}</a>.</span> | ||
| </small> | ||
| <!-- <small class="text-muted">{{'browse.startsWith.type_text' | translate}}</small> --> | ||
| <!-- END TAMU Customization - starts with input hint accessibility update --> | ||
| </div> | ||
| </form> |
Empty file.
34 changes: 34 additions & 0 deletions
34
src/themes/tamu/app/shared/starts-with/text/starts-with-text.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { Component } from '@angular/core'; | ||
| import { | ||
| FormsModule, | ||
| ReactiveFormsModule, | ||
| } from '@angular/forms'; | ||
| // TAMU Customizations | ||
| import { RouterLink } from '@angular/router'; | ||
| // END TAMU Customizations | ||
| import { TranslateModule } from '@ngx-translate/core'; | ||
|
|
||
| import { StartsWithTextComponent as BaseComponent } from '../../../../../../app/shared/starts-with/text/starts-with-text.component'; | ||
| import { StartsWithType } from '../../../../../../app/shared/starts-with/starts-with-type'; | ||
| import { renderStartsWithFor } from '../../../../../../app/shared/starts-with/starts-with-decorator'; | ||
|
|
||
|
|
||
| @Component({ | ||
| selector: 'ds-starts-with-text', | ||
| // styleUrls: ['./starts-with-text.component.scss'], | ||
| styleUrls: ['../../../../../../app/shared/starts-with/text/starts-with-text.component.scss'], | ||
| templateUrl: './starts-with-text.component.html', | ||
| // templateUrl: '../../../../../../app/shared/starts-with/text/starts-with-text.component.html', | ||
| standalone: true, | ||
| imports: [ | ||
| FormsModule, | ||
| ReactiveFormsModule, | ||
| // TAMU Customizations | ||
| RouterLink, | ||
| // END TAMU Customizations | ||
| TranslateModule, | ||
| ], | ||
| }) | ||
| @renderStartsWithFor(StartsWithType.text) | ||
| export class StartsWithTextComponent extends BaseComponent { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.