fix: resolve pre-existing cofferdam findings#64
Open
TAJD wants to merge 4 commits into
Open
Conversation
Fixes the workspace-scoping invariant to reflect group-based project access (PROJ-311), tightens the lefthook section, dedupes three near-identical CI-command listings to one canonical block, and removes a brittle/duplicated spawn-prompt section. Also drops the duplicate D1 bound-parameter-limit paragraph from sql.ts's header comment now that AGENTS.md points at the code instead of restating it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011hs2GEFcYVcUtQrYTvsgwa
Triaged all findings from `cofferdam check` against the repo: - removed a stale Consistency.UnusedSuppression on groups.test.ts - dropped an unused GrantRoleEnum export (Design.OrphanExport) - gave requireProjectAccess a resource-specific notFoundMessage param so it's now genuinely reused by assertIssueProjectVisible instead of sitting orphaned (Design.OrphanExport) - extracted GroupsSection out of GroupManager to fix its Readability.LongAndComplex finding - suppressed the two 2-occurrence Refactor.DuplicateBlock findings in groups.ts (removeGroupMember/removeGroupGrant) and sprints.test.ts (viewer-cannot-update/delete), with a reason comment rather than forcing an abstraction over two call sites - suppressed GroupManager's default export as a Design.OrphanExport false positive (astro imports aren't parsed by cofferdam's import graph) - wrapped 6 over-length lines flagged by Readability.MaxLineLength Verified with `cofferdam check` (0 findings), `turbo type-check` (0 errors), and the groups/sprints/issues vitest suites (129 passing).
Rebasing onto main (PROJ-314 group-access epic) pulled in two new findings: - a stale Readability.MaxFunctionLength suppression on coordination-access.test.ts's describe block (well under the limit) - a Readability.MaxLineLength overflow in AccessPending.tsx Verified with `cofferdam check` (0 findings), `turbo type-check` (0 errors), and the full API vitest suite (614/619, 5 todo, 0 failed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cofferdam checkrun: a stale suppression, an orphaned export (turned into a genuinely-reused helper param), a long/complex island component (extracted a sub-component), two 2-occurrence duplicate-block findings (suppressed with reasoning rather than forcing an abstraction), an Astro-import false-positive orphan export, and several over-length lines.AccessPending.tsx).Test plan
cofferdam check— 0 findingsturbo type-check— 0 errors across all 7 packagesbiome checkclean