Skip to content

Fix: Sync the default ban type with Grappa's account setting - #273

Merged
Sythos merged 1 commit into
mainfrom
enya/issue-271-sync-the-default-ban-type-with-grappa-s
Oct 8, 2026
Merged

Sythos merged 1 commit into
mainfrom
enya/issue-271-sync-the-default-ban-type-with-grappa-s

Conversation

@Sythos

@Sythos Sythos commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Closes #271

Not included in this pull request:

  • Bump CLIENT_PROTOCOL_VERSION to 38 after checking the Grappa v38 source for other protocol changes. I left it at 37 because I couldn't check, and the setting doesn't depend on the declared version.
  • Try the setting against a real Grappa server running protocol 38, including a pre-38 server.

@Sythos Sythos self-assigned this Oct 8, 2026
@Sythos Sythos added the Enya: check review PR: checks are green, waiting for reviews label Oct 8, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T15:26:44.560776Z 1123fdc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Sythos Sythos added Enya: reviewed PR: reviews handled, waiting for the merge worker and removed Enya: check review PR: checks are green, waiting for reviews labels Oct 8, 2026
@Sythos
Sythos merged commit ec69195 into main Oct 8, 2026
9 checks passed
@Sythos
Sythos deleted the enya/issue-271-sync-the-default-ban-type-with-grappa-s branch October 8, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enya: reviewed PR: reviews handled, waiting for the merge worker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync the default ban type with Grappa's account setting

1 participant