Restrict Agent FFmpeg tools to read-only inspection - #1
Draft
LittleLaXerath wants to merge 1 commit into
Draft
LittleLaXerath wants to merge 1 commit into
LittleLaXerath wants to merge 1 commit into
Conversation
Keep only ffmpeg_probe and ffmpeg_loudness_analyze in the conversational Agent surface. Preserve prepare and loudness_normalize behind the stable C ABI so pi-desktop can present the plan and require explicit user confirmation before creating WAV files. Add exact permission-boundary tests, update the component contract and README, and include a detailed bilingual changelog. The component lifecycle remains user-triggered and the finite FFmpeg allow-list is unchanged. 中文:将对话智能体可见的 FFmpeg 能力收紧为文件探测与响度分析两个只读工具;保留 C ABI 中的音频准备和响度标准化能力,交由 pi-desktop 展示操作计划并在写入 WAV 前取得用户明确确认。同步补充权限边界测试、契约文档、README 与中英文更新日志。 Validation: 57 Rust workspace tests passed with 2 intentionally ignored; Clippy passed with -D warnings; all four allow-listed operations passed against a real local FFmpeg build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
中文
更新内容
ffmpeg_probe与ffmpeg_loudness_analyze两个只读操作。ffmpeg_prepare_audio和ffmpeg_loudness_normalize的定义与执行路由,避免对话模型未经确认写入音频文件。pi-desktop,由桌面界面展示计划并取得用户确认。CHANGELOG.md。验证
-D warnings通过。English
Changes
ffmpeg_probeandffmpeg_loudness_analyzetools.ffmpeg_prepare_audioandffmpeg_loudness_normalize, preventing unconfirmed audio-file writes by the conversational model.pi-desktop, where the user can review and confirm the action.CHANGELOG.md.Validation
-D warnings.