Repository navigation
fix: make routed smart-order parents venue-neutral - #44
Merged
Richard-LZ-Zhang merged 4 commits intoOct 26, 2026
Merged
Richard-LZ-Zhang merged 4 commits into
Richard-LZ-Zhang merged 4 commits into
Conversation
Richard-LZ-Zhang
marked this pull request as ready for review
October 26, 2026 00:13
Richard-LZ-Zhang
merged commit Oct 26, 2026
7084154
into
codex/order-lifecycle-storage
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A routed bucket parent previously inherited the first enabled member's venue/account even when its children executed elsewhere. Parents now belong to the existing user, have null execution venue/account and save the exact eligible
execution_accountsmap; children retain concrete venue/accounts.Authorization, conservative full-quantity admission and execution use one captured bucket/account scope. Parent snapshot, indexed membership, readable projection and related events commit atomically. Parent reads/actions/reports, HTTP audit history and live/replayed events enforce saved-scope permissions. Recovery and cleanup refuse changed configured or adapter accounts before venue I/O; ambiguous legacy retries cannot duplicate execution.
Logical schema 11 / Alembic
0006_routed_execution_scopepreserves IDs and fills, rekeys parent projections and refuses missing/conflicting historical account evidence unless a reviewed explicit mapping supplies missing identities. Order-list cursor format is v2 and old cursors are rejected. Existing lifecycle status semantics remain unchanged.Targets only
codex/order-lifecycle-storage. No public-main merge, release, production pin change or actual trades.Test Coverage and Verification
Full suites ran at
7bfb56f; subsequent bounded-query assertions and the locale-portable pagination check pass at final148ea2e, including the full Python 3.10/3.12/3.13 and PostgreSQL CI matrix.Final-commit CI checks
Pre-Landing Review
Independent security/storage reviews cleared their findings after fixes. Completion audit's four coverage gaps are closed; no material implementation gaps remain. The external review CLI could not initialize, so fresh-context agent reviews supplied the independent review. No frontend changes; no design review or model evals required.
Plan Completion
Approved T1–T3 and D6/D7 audit-route/recovery safeguards are implemented and verified offline. Merged into the designated experimental branch at
708415477a0d999db09bb742fd539d062456d7db. Normal workspace setup and installed-consumer verification pass against that clean merged branch tip; workspace CI gates its companion landing.Documentation
Engine/lifecycle and migration guides document the new contract, historical-account mapping, backup/restore and downgrade limits. Broader uncertain-send/resynchronization limitations remain explicit.
Companion workspace PR #114 includes the verification report, actual inputs/outputs and screenshots. The workspace repository requires access.
Related: https://linear.app/synpath/issue/PRE-6/remove-arbitrary-nominal-venue-from-cross-venue-smart-order-parents