Repository navigation
Delete the broker client and the curated APIs that could only fail - #193
Conversation
FRED, NewsAPI and Metaculus refuse browser calls, so without a broker they can never return data on any deployment. Installing one only collected a visitor's key, POSTed it to a 503 stub and showed an error. Removes them with the broker client, provider attribution, the key-format warning no remaining API can trigger, cited-block highlighting and the always-empty keyed-provider check. transport.access stays on the manifest because it is part of the digest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1625ab630
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…jects them on rehydrate Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Codex feedback round 1 answered 1 of 1 Codex finding(s). |
A backup can hold a FRED, NewsAPI or Metaculus manifest, or an older MCP or async one. Restore must keep the canvas and drop only that capability, and a malformed entry must still be refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Objective. Continue #190 under the same rule: delete what no live deployed app can reach. Main point: stop visitors' keys going to a stub. Net −763 lines.
What changed.
executeBroker, thebrokerOriginsoption and the "via server" UI are gone. Before this, a key entered for a brokered API was POSTed to/api/capability-broker, which returned 503.envVarfield, four type-only fields, and thedev:vinextandbuild:vinextscripts.What did not change.
wrangler.jsonc,.env.example,deploy-preview.ymland.mcp.jsonare untouched.transport.accessstays on every manifest asbrowser_direct, because it is part of the digest and removing it would invalidate every installed capability.SECRET_ENV_VARSstays broad on purpose.Visible differences once deployed.
server_brokermanifest, which validation now rejects, so it is dropped on restore. Those blocks could never return data.a542114).restoreSnapshotstill validates each manifest and drops the bad one, and a non-object entry is still refused. This also covers old backups holding MCP or async manifests, which Delete every path no live deployment reaches #190 would have refused.Tests run (clean build):
typecheckpasses.linthas 0 errors.npm test: 840 passed, 92 files.build, wrangler dry run andscan:bundlewith canaries pass.test:e2eonnext start: 7 of 7.wrangler devanswers as expected on/, the five stubs,/api/polymarketand/api-index.json.Known failures. None. Coverage note: nothing now exercises a key sent in an
X-Api-Keyheader compiled from a curated spec; the Metaculus and NewsAPI cases were that coverage.Claim ceiling. Tested locally. Not deployed.
Architectural decisions introduced. None.
Evidence that could falsify it. A deployment with a working broker, which the Cloudflare account does not show.
Next permissible package. The owner deploys, and removes the stubs together with their
deploy-preview.ymlchecks.🤖 Generated with Claude Code