fix: session_script.sh: magic line has to be first

[sambuc]

The magic line/interpreter line has to be the first of the file, otherwise it is simply ignored.

[leafty]

???
The comments are removed before submission. This script is not meant to be executed "AS IS", which is the point of the NOTE FOR AMALTHEA MAINTAINERS at the top.

See templating code:

amalthea/internal/remote/firecrest/controller.go

Lines 602 to 674 in b9823e1

	func (c *FirecrestRemoteSessionController) renderSessionScript(sessionScript string, fileSystems *[]FileSystem, secretsPath string) string {
	return renderSessionScriptStatic(sessionScript, c.partition, fileSystems, secretsPath)
	}
	func renderSessionScriptStatic(sessionScript, partition string, fileSystems *[]FileSystem, secretsPath string) string {
	sessionScriptFinal := removeMaintainersNotesFromScript(sessionScript)
	sessionScriptFinal = addSbatchDirectivesToScript(sessionScriptFinal, partition)
	sessionScriptFinal = addSessionMountsToScript(sessionScriptFinal, fileSystems, secretsPath)
	return sessionScriptFinal
	}
	func removeMaintainersNotesFromScript(sessionScript string) string {
	return sessionScriptNoteRegExp.ReplaceAllString(sessionScript, "")
	}
	func addSbatchDirectivesToScript(sessionScript, partition string) string {
	directives := []string{
	"#SBATCH --nodes=1",
	"#SBATCH --ntasks-per-node=1",
	}
	if partition != "" {
	directives = append(directives, fmt.Sprintf("#SBATCH --partition=%s", partition))
	}
	// The slurm account can be set by the user as an environment variable
	slurmAccount := os.Getenv("USER_ENV_SLURM_ACCOUNT")
	if slurmAccount != "" {
	directives = append(directives, fmt.Sprintf("#SBATCH --account=%s", slurmAccount))
	}
	directivesStr := strings.Join(directives, "\n")
	return strings.Replace(sessionScript, "#{{SBATCH_DIRECTIVES_PLACEHOLDER}}", directivesStr, 1)
	}
	func addSessionMountsToScript(sessionScript string, fileSystems *[]FileSystem, secretsPath string) string {
	if fileSystems == nil {
	return strings.Replace(sessionScript, "#{{SESSION_MOUNTS_PLACEHOLDER}}", "", 1)
	}
	// Collect file systems we want to mount
	var home *FileSystem
	scratches, stores := []*FileSystem{}, []*FileSystem{}
	for _, fs := range *fileSystems {
	switch fs.DataType {
	case Scratch:
	scratches = append(scratches, &fs)
	case Store:
	stores = append(stores, &fs)
	case Users:
	home = &fs
	}
	}
	mounts := []string{}
	for _, scratch := range scratches {
	mounts = append(mounts, scratch.Path)
	}
	for _, store := range stores {
	mounts = append(mounts, store.Path)
	}
	// TODO: Try to mount home at its location (need to handle ~/.bashrc)
	// TODO: Alternatively, copy the contents in the container
	if home != nil {
	mounts = append(mounts, fmt.Sprintf("%s:/home%s:ro", home.Path, home.Path))
	}
	// Add the secrets mount
	mounts = append(mounts, fmt.Sprintf("%s:/secrets:ro", secretsPath))
	// Format mount list
	for i := range mounts {
	mounts[i] = fmt.Sprintf(" \"%s\",", mounts[i])
	}
	mountsStr := fmt.Sprintf("mounts = [\n%s\n]", strings.Join(mounts, "\n"))
	return strings.Replace(sessionScript, "#{{SESSION_MOUNTS_PLACEHOLDER}}", mountsStr, 1)
	}

[leafty]

This should be tested on staging.

[sambuc]

This is currently deployed on staging via SwissDataScienceCenter/renku#4261

[leafty]

LGTM, checked rendered job script.