Skip to content

[codex] Hide CFP speaker callout on home page#183

Merged
Sherlouk merged 6 commits into
SwiftLeeds:cfpholdfrom
NoamEfergan:codex/hide-cfp-speaker-callout
Jul 7, 2026
Merged

[codex] Hide CFP speaker callout on home page#183
Sherlouk merged 6 commits into
SwiftLeeds:cfpholdfrom
NoamEfergan:codex/hide-cfp-speaker-callout

Conversation

@NoamEfergan

Copy link
Copy Markdown
Contributor

What changed

Removed the home-page fallback that rendered the CFP speaker callout when no speakers were announced.

Why

The site should no longer show the "We are looking for speakers" call for papers section on the home page.

Impact

When speakers exist, the speaker section still renders as before. When no speakers exist, the home page now skips the CFP callout instead of linking visitors to /cfp from that section.

Validation

  • Confirmed the working tree only includes Resources/Views/Home/home.leaf.
  • Attempted swift build, but stopped it after several minutes while SwiftPM was still fetching the large aws-sdk-swift dependency and had not reached compilation.

@NoamEfergan NoamEfergan marked this pull request as ready for review June 2, 2026 11:50
@Sherlouk

Sherlouk commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

This is somewhat intentional, it's all synced to Sessionize and as soon as we populate speakers it'll switch modes

@adamrushy

Copy link
Copy Markdown
Contributor

I wonder if it's better to just change this title:

Screenshot 2026-06-02 at 17 37 09

So it better reflects the state of Sessionize, but keep the "Learn more" button because this takes people to a full page on CFP that explains how the process works, WDYT?

@Sherlouk

Sherlouk commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

We'd need to start caching that state somewhere, wouldn't want to put the main homepage behind Sessionise API as that'll just lead to rate limits and more error cases

@adamrushy

Copy link
Copy Markdown
Contributor

We'd need to start caching that state somewhere, wouldn't want to put the main homepage behind Sessionise API as that'll just lead to rate limits and more error cases

Yeah, easy enough to do right - could even stick it in the DB that's cache for X days or even weeks to be honest as it doesn't change that often

@Sherlouk

Sherlouk commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Get codex on it Nowham

Maybe save it on the event obj

@NoamEfergan

Copy link
Copy Markdown
Contributor Author

Implemented the event-level CFP flag on this branch.

Changes:

  • Added Event.cfpClosed backed by a new cfp_closed column with default true.
  • Added and registered EventMigrationV7.
  • Exposed cfpClosed to Leaf via EventContext.
  • Updated the home page to show Home/_cfp only when there are no speakers and cfpClosed is false.
  • Added a CFP closed? switch to the admin event form and persisted it through the event controller.

Validation:

  • git diff --check passes.
  • Attempted swift build in sandbox and with elevated permissions, but both runs stayed in the aws-sdk-swift dependency fetch phase and were stopped before compilation. swift test was not run because build never reached compile.

Comment thread Resources/Views/Admin/Form/event_form.leaf Outdated
Co-authored-by: James Sherlock <15193942+Sherlouk@users.noreply.github.com>
@NoamEfergan NoamEfergan requested a review from Sherlouk June 22, 2026 12:28

@Sherlouk Sherlouk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, let's push to staging and test

Fork pull_request runs don't receive repository secrets, so the
"Login to Google Artifact Registry" step failed with "Password required".
Gate the registry login, image push, and deploy job on same-repo events so
fork PRs still lint, test, and compile the release build without attempting
secret-dependent steps.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@NoamEfergan

Copy link
Copy Markdown
Contributor Author

@Sherlouk i've had to add a rule there because deploy can't happen on forked PRs. if it's wrong let me know, i think you need to approve the deply

@Sherlouk Sherlouk changed the base branch from main to cfphold July 7, 2026 11:11
@Sherlouk Sherlouk merged commit 60c68de into SwiftLeeds:cfphold Jul 7, 2026
@Sherlouk

Sherlouk commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Merging into an org-owned branch for testing

@Sherlouk Sherlouk mentioned this pull request Jul 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants